Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redhat): don't return error if root/buildinfo/content_manifests/ contains files that are not contentSets files #7912

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

DmitriyLewen
Copy link
Contributor

Description

We return empty BuildInfo if root/buildinfo/content_manifests/*.json doesn't contain contentSets.
But if root/buildinfo/content_manifests/ doesn't have file with contentSets - we return error (because we don't use default contentSets)

That is why we need to return nil if contentSets are not found.

See #7911 to get example.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into aquasecurity:main with commit 38775a5 Nov 18, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix/content-manifest-nil branch November 18, 2024 08:04
@DmitriyLewen
Copy link
Contributor Author

@aqua-bot backport release/v0.57

@aqua-bot
Copy link
Contributor

Backport PR created: #7939

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(redhat): we don't need to return error if redhat image doesn't contain content_sets
3 participants