Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(db): fix javadb downloading error handling #7642

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix(db): fix javadb downloading error handling #7642

merged 2 commits into from
Oct 3, 2024

Conversation

nikpivkin
Copy link
Contributor

Description

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin
fix(db): fix javadb downloading error handling
72e827d 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@knqyf263 knqyf263 requested a review from DmitriyLewen October 3, 2024 11:03
DmitriyLewen
DmitriyLewen reviewed Oct 3, 2024
View reviewed changes
pkg/javadb/client.go Outdated Show resolved Hide resolved
@nikpivkin
chore: update error msg
3575c18 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@nikpivkin nikpivkin marked this pull request as ready for review October 3, 2024 12:04
@knqyf263 knqyf263 added this pull request to the merge queue Oct 3, 2024
@knqyf263 knqyf263 mentioned this pull request Oct 3, 2024
Open
Merged via the queue into aquasecurity:main with commit 2c87f0c Oct 3, 2024
12 checks passed
@nikpivkin
Copy link
Contributor Author

@aqua-bot backport release/v0.56

@nikpivkin nikpivkin deleted the db-err branch October 3, 2024 12:34
github-actions bot pushed a commit that referenced this pull request Oct 3, 2024
@nikpivkin @actions-user
fix(db): fix javadb downloading error handling (#7642)
d5db649 
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
@aqua-bot aqua-bot mentioned this pull request Oct 3, 2024
Merged
@aqua-bot
Copy link
Contributor

aqua-bot commented Oct 3, 2024

Backport PR created: #7646

@aqua-bot aqua-bot mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitriyLewen DmitriyLewen DmitriyLewen approved these changes

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikpivkin @aqua-bot @knqyf263 @DmitriyLewen