fix(misconf): properly expand dynamic blocks #7612
Conversation
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
| @@ -567,7 +567,7 @@ resource "something" "else" { | |||
| for_each = toset(["true"]) | |||
|
|
|||
| content { | |||
| ok = each.value | |||
| ok = blah.value | |||
There was a problem hiding this comment.
For reviewers: this test should not have run successfully because dynamic blocks do not create an each object.
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
pkg/iac/terraform/block.go
Outdated
| if forEachVal.IsNull() || !forEachVal.IsKnown() { | ||
| return cty.NilVal, errors.New("cannot use a null or unknown value in for_each") | ||
| } |
There was a problem hiding this comment.
In my coverage this seems to be untested so I decided to investigate. Would this ever be reached since we already check for !forEachVal.CanIterateElements() prior to this? If you have a sample input, it'd be nice to understand.
There was a problem hiding this comment.
Yes, this check is unreachable, I removed it. 4d3de2a
Signed-off-by: nikpivkin <nikita.pivkin@smartforce.io>
|
It looks like the issue is still there (0.57.0): I'm using the same module as before (https://github.com/Azure/terraform-azurerm-avm-res-compute-virtualmachine/blob/main/main.backup.tf) |
|
I'm seeing similar issues still with 0.57.0: |
|
Hi @stewartcampbell ! You are using blocks of data that cannot be analyzed statically in some cases #7731 (comment) |
Description
This PR separates the logic for expanding dynamic blocks from expanding the
for-eachmeta argument.Related issues
Checklist