Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show progress when fetching layers #330

Open
knqyf263 opened this issue Dec 16, 2019 · 1 comment · May be fixed by #8186
Open

Show progress when fetching layers #330

knqyf263 opened this issue Dec 16, 2019 · 1 comment · May be fixed by #8186
Assignees
@nikpivkin
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v0.59.0

Comments

@knqyf263
Copy link
Collaborator

Like Docker

98567ebe879d: Already exists
d642a782e293: Pull complete
cf233c8d5a07: Pull complete
dfc5ad175a50: Downloading [=====>                                             ]  4.552MB/44.45MB
bc51f9ffb51a: Downloading [=>                                                 ]  427.6kB/20.59MB
2498a6ce9a1a: Download complete
93be64bef785: Waiting
@knqyf263 knqyf263 added the kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. label Dec 16, 2019
@knqyf263 knqyf263 added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Apr 30, 2020
@yashvardhan-kukreja
Copy link
Contributor

yashvardhan-kukreja commented Sep 24, 2020 •
edited
Loading

I dug into this and this seems like more of an issue/enhancement on the side of fanal.
Because the "Inspect" function which is the entry point for an image to get scanned is a part of fanal under artifact/image/image.go
Entrypoint:

trivy/pkg/scanner/scan.go

Line 85 in 014be7e

artifactInfo, err := s.artifact.Inspect(ctx)

Function performing the scan:
https://github.com/aquasecurity/fanal/blob/1b5f79c38073afe1a11ee19fe1f1095535dc6ce8/artifact/image/image.go#L33-#L60

@yashvardhan-kukreja yashvardhan-kukreja mentioned this issue Sep 26, 2020
Open
liamg pushed a commit that referenced this issue Jun 7, 2022
@rahul2393
chore: update go-dep-parser dependency to fix pip parsing issue (#330)
16509b8
liamg pushed a commit that referenced this issue Jun 7, 2022
@rahul2393
chore: update go-dep-parser dependency to fix pip parsing issue (#330)
628ff1d
@knqyf263 knqyf263 added this to the v0.59.0 milestone Dec 26, 2024
@nikpivkin nikpivkin linked a pull request Dec 26, 2024 that will close this issue
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikpivkin nikpivkin

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
Trivy Roadmap
Status: No status
Milestone
v0.59.0
Development

Successfully merging a pull request may close this issue.

feat(image): add progress bar for image layer pulling nikpivkin/trivy
3 participants
@knqyf263 @yashvardhan-kukreja @nikpivkin