fix(pom): compare ArtifactIDs for base and parent pom's when relativePath field is used
#267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Oct 28, 2023
pkg/java/pom/parse.go
Outdated
| @@ -510,6 +510,13 @@ func (p *parser) tryRelativePath(parentArtifact artifact, currentPath, relativeP | |||
| return nil, err | |||
| } | |||
|
|
|||
| // We can inherit GroupID from parent (requires p.analyze function to get GroupID) | |||
| // Version can contain a property (requires p.analyze function to get version) | |||
| // But ArtifactID must be the same for parent and base poms | |||
There was a problem hiding this comment.
What do you mean? The parent artifact id and the base artifact id won't match.
Do you mean, "The artifact id of the parent pom in the base pom and the actual artifact id in the parent pom must match."?
There was a problem hiding this comment.
Right!
But i see that this comment may be confusing.
I updated comment in cedc6ce :
Take a look, please.
knqyf263
approved these changes
Oct 30, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to compare
ArtifactIDs for base and parent pom's whenrelativePath == ../pom.xmlis used.it is needed to avoid cases when we get incorrect parent or get infinity loop (if
../pom.xmlis scanned pom.xml).We can inherit
GroupID. AlsoVersioncan contains property.So we need to compare only
ArtifactID.New test contains simple example - https://github.com/DmitriyLewen/go-dep-parser/blob/7d2c865da8912f9f3ea475cc94da61c819dcae0d/pkg/java/pom/parse_test.go#L987-L999
Example from real life - aquasecurity/trivy/discussions/5445
Related Issues
parent path + ../pom.xmlequals scanned pom.xml trivy#5453