Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logo #403

Merged
merged 3 commits into from
Nov 20, 2021
Merged

chore: add logo #403

merged 3 commits into from
Nov 20, 2021

Conversation

vadasambar
Copy link
Contributor

@vadasambar vadasambar commented Nov 18, 2021

Considerations

  • Something that incorporates the image of water (aqua) and package
  • Minimalistic: should express the idea with less design components
  • Scalable: should look good irrespective of the scale (favicon, t-shirts, print-outs and everything else)
  • Built with open source:

@vadasambar vadasambar marked this pull request as ready for review November 18, 2021 15:48
@vadasambar vadasambar changed the title Chore/add logo chore: add logo Nov 18, 2021
@@ -1,4 +1,8 @@
# aqua
<p align="center" width="100%">
<img src="./logo/aqua_horizontal.svg" width="400">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can check how it looks in the README here.

@@ -0,0 +1,122 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
Copy link
Contributor Author

@vadasambar vadasambar Nov 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG files are stored as XML

Scalable Vector Graphics (SVG) is an XML-based vector image format for two-dimensional graphics with support for interactivity and animation.

https://en.wikipedia.org/wiki/Scalable_Vector_Graphics

@vadasambar
Copy link
Contributor Author

@suzuki-shunsuke, can you please review this when you find free time 🙏
Thank you!

@suzuki-shunsuke suzuki-shunsuke self-requested a review November 20, 2021 04:15
Copy link
Member

@suzuki-shunsuke suzuki-shunsuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!
The logo is very cool. I love it.

@suzuki-shunsuke suzuki-shunsuke added this to the v0.7.17 milestone Nov 20, 2021
@suzuki-shunsuke suzuki-shunsuke added the documentation Improvements or additions to documentation label Nov 20, 2021
@suzuki-shunsuke suzuki-shunsuke merged commit b6195af into aquaproj:main Nov 20, 2021
@suzuki-shunsuke
Copy link
Member

Added the description. #405

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants