feat: support fish completion #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reitzig
reviewed
May 31, 2024
pkg/cli/completion.go
Outdated
Comment on lines
32
to
34
| if command -v aqua &> /dev/null; | ||
| aqua completion fish | source | ||
| end |
There was a problem hiding this comment.
FWIW, that does not seem to be the recommended way: https://fishshell.com/docs/current/completions.html#where-to-put-completions
(I used that command in the issue for brevity and because it tests the command output; sorry if that was confusing.)
Rather, I would manually run
aqua completion fish > .config/fish/completions/aqua.fishonce after installation/upgrade. No additional hook is necessary.
There was a problem hiding this comment.
Thank you for your review.
Fixed. dee19a2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2927
Add a subcommand
aqua completion fish, which outputs the shell completion for fish.