Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recent entities and incoming entity change #8342

Merged
merged 3 commits into from
Oct 11, 2021
Merged

fix: recent entities and incoming entity change #8342

merged 3 commits into from
Oct 11, 2021

Conversation

ApekshaBhosale
Copy link
Contributor

@ApekshaBhosale ApekshaBhosale commented Oct 8, 2021 •
edited by github-actions bot
Loading

Description

  1. JSObject was not appearing in recent entities
  2. incoming entities was not able go to respective JSObject

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: js-entity-changes
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.94 (-0.01) 36.66 (-0.02) 33.87 (0) 55.51 (-0.01)
🔴 app/client/src/components/editorComponents/Debugger/hooks/debuggerHooks.ts 33.72 (-0.01) 0 (0) 7.14 (0) 33.33 (0)
🔴 app/client/src/components/editorComponents/Debugger/hooks/useGetEntityInfo.tsx 32.43 (-3.93) 0 (0) 0 (0) 32.35 (-4.32)
🔴 app/client/src/components/editorComponents/GlobalSearch/utils.tsx 69.29 (0) 25.22 (-0.22) 60.87 (0) 69.31 (0)
🔴 app/client/src/selectors/commentsSelectors.ts 78.23 (-1.61) 54.41 (-2.94) 70 (0) 84.09 (-2.27)

@ApekshaBhosale ApekshaBhosale requested a review from arunvjn October 8, 2021 09:28
@ApekshaBhosale ApekshaBhosale changed the title recent entities and incoming entity change fix: recent entities and incoming entity change Oct 8, 2021
@github-actions github-actions bot added the Bug Something isn't working label Oct 8, 2021
@ApekshaBhosale ApekshaBhosale requested a review from arunvjn October 8, 2021 10:41
@ApekshaBhosale ApekshaBhosale requested a review from arunvjn October 8, 2021 14:10
@ApekshaBhosale ApekshaBhosale merged commit 5eb292a into release Oct 11, 2021
@ApekshaBhosale ApekshaBhosale deleted the js-entity-changes branch October 11, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arunvjn arunvjn arunvjn approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ApekshaBhosale @arunvjn