Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle extra Java arguments to server Docker image #8244

Merged
merged 1 commit into from
Oct 8, 2021
Merged

feat: Handle extra Java arguments to server Docker image #8244

merged 1 commit into from
Oct 8, 2021

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented Oct 6, 2021

Currently, there's no way to specify custom memory settings to the server Docker image. The changes in this PR will allow providing any custom Java arguments as part of CMD for the server Docker image. This means custom memory settings can now be specified like:

docker run appsmith/appsmith-server -Xmx1024m

@sharat87 sharat87 added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Oct 6, 2021
@sharat87 sharat87 requested a review from mohanarpit October 6, 2021 10:05
@github-actions github-actions bot added Enhancement New feature or request and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Oct 6, 2021
@mohanarpit mohanarpit merged commit d9c7de2 into release Oct 8, 2021
@mohanarpit mohanarpit deleted the feat/handle-extra-args-server-docker branch October 8, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanarpit mohanarpit mohanarpit approved these changes

Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharat87 @mohanarpit @Nikhil-Nandagopal