fix: tooltip will disabled on button widget #8209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somangshu
approved these changes
Oct 5, 2021
| @@ -106,10 +106,6 @@ const RecaptchaWrapper = styled.div` | |||
| } | |||
| `; | |||
|
|
|||
| const ToolTipContent = styled.div` | |||
There was a problem hiding this comment.
What are we removing this, Wont the large content flow outside the screen?
There was a problem hiding this comment.
@somangshu Here we moved this CSS globally in another PR and it was already merged in the release branch.
so we do not require this.
There was a problem hiding this comment.
Can you point out the code here? Good catch by the way.
There was a problem hiding this comment.
@somangshu you can check here
|
@techbhavin can we write some cypress test around the button widget tootip disabled on button disabled |
somangshu
previously approved these changes
Oct 5, 2021
|
@techbhavin Verified this fix and it is working as expected |
somangshu
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7554
Type of change
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased