Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve product copy by removing improper character capitalization #7911

Merged
merged 4 commits into from
Oct 8, 2021

Conversation

areyabhishek
Copy link
Contributor

@areyabhishek areyabhishek commented Sep 28, 2021

Description

There are copy places in Appsmith where the capitalization of words is inconsistent. I've replaced everything with sentence case

Fixes #7910

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Used my eyes to test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

Updated the copy and removed places where things were capitalized inconsistently
@areyabhishek areyabhishek changed the title Update messages.ts Improve product copy by removing improper character capitalization Sep 28, 2021
@mohanarpit mohanarpit changed the title Improve product copy by removing improper character capitalization chore: Improve product copy by removing improper character capitalization Sep 29, 2021
mohanarpit
mohanarpit previously approved these changes Sep 29, 2021
@mohanarpit mohanarpit enabled auto-merge (squash) September 29, 2021 06:07
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Sep 29, 2021
app/client/src/constants/messages.ts Outdated Show resolved Hide resolved
export const ONBOARDING_TASK_WIDGET_FOOTER_ACTION = () =>
"deploy your application";
export const ONBOARDING_TASK_FOOTER = () => "Alternatively, you can also";

export const USE_SNIPPET = () => "Snippet";
export const SNIPPET_TOOLTIP = () => "Search Snippets";
export const SNIPPET_TOOLTIP = () => "Search snippets";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be Search JS snippets to be consistent with OMNIBAR_PLACEHOLDER_SNIPPETS ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with you. I'll update this

@mohanarpit mohanarpit disabled auto-merge September 29, 2021 06:23
Updated with fixes for a spelling mistake and made changes to code snippets
sbalaji1192
sbalaji1192 previously approved these changes Sep 30, 2021
@github-actions
Copy link

github-actions bot commented Oct 7, 2021

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Oct 7, 2021
@mohanarpit mohanarpit merged commit daeaf44 into release Oct 8, 2021
@mohanarpit mohanarpit deleted the areyabhishek-copy-updates branch October 8, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]-[4000]:Fix inconsistent copy in Appsmith product
3 participants