Fix Hackney pool saturation #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ All good! |
This relates to the issue reported in #970, where the default Hackney pool is drained of connections by the check-ins sent by the transmitter. This does not fix the issue, but ensures that it is a separate pool, used only by the AppSignal transmitter, that is drained of connections, rather than the default one, which may be used by the customer's code.
unflxw
force-pushed
the
fix-hackney-pool-saturation
branch
from
80827bf to
d500693
Compare
Make sure that Hackney connections are closed after use. This fixes an issue where the Hackney pool does not correctly claim back connections, which fixes #970. Implement a `transmit_and_close/3` convenience method in the transmitter for use cases where the body is not of interest, meaning that the connection can be immediately closed.
unflxw
force-pushed
the
fix-hackney-pool-saturation
branch
from
d500693 to
7233adf
Compare
jeffkreeftmeijer
approved these changes
Nov 6, 2024
tombruijn
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use separate Hackney pool for transmitter
This relates to the issue reported in #970, where the default Hackney
pool is drained of connections by the check-ins sent by the
transmitter. This does not fix the issue, but ensures that it is
a separate pool, used only by the AppSignal transmitter, that is
drained of connections, rather than the default one, which may be
used by the customer's code.
Close Hackney connections after use
Make sure that Hackney connections are closed after use. This fixes
an issue where the Hackney pool does not correctly claim back
connections, which fixes #970.
Implement a
transmit_and_close/3convenience method in thetransmitter for use cases where the body is not of interest, meaning
that the connection can be immediately closed.