Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "FileOperations: Add Windows implementation for FileDescriptor.resize(to:)" #93

Merged
merged 1 commit into from
Jun 11, 2022
Merged

Revert "FileOperations: Add Windows implementation for FileDescriptor.resize(to:)" #93

merged 1 commit into from
Jun 11, 2022

Conversation

lorentey
Copy link
Member

@lorentey lorentey commented Jun 11, 2022 •
edited
Loading

Reverts #89

Resolves #92.

@lorentey
Copy link
Member Author

@swift-ci test

@lorentey lorentey linked an issue Jun 11, 2022 that may be closed by this pull request
Windows build is broken #92
Closed
@lorentey
Copy link
Member Author

Cc @milseman @simonjbeaumont

Please let's not do this again in the future.

@lorentey lorentey merged commit 025bcb1 into main Jun 11, 2022
@lorentey lorentey deleted the revert-89-sb/resize-windows branch June 11, 2022 19:57
@lorentey lorentey mentioned this pull request Jun 11, 2022
Closed
TECHhero2016
TECHhero2016 approved these changes Oct 29, 2023
View reviewed changes
Copy link

@TECHhero2016 TECHhero2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TECHhero2016 TECHhero2016 TECHhero2016 approved these changes

@simonjbeaumont simonjbeaumont Awaiting requested review from simonjbeaumont

@milseman milseman Awaiting requested review from milseman milseman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows build is broken
2 participants
@lorentey @TECHhero2016