Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip locking package build directory #84

Merged
merged 3 commits into from
Mar 3, 2024
Merged

Conversation

rauhul
Copy link
Collaborator

@rauhul rauhul commented Feb 29, 2024

SwiftPM 6 introduces a lock in the package build directory to avoid concurrent builds/tests. Unfortuntely this behavior is needed by the MMIOFileCheckTests currently. This commit adds a flag to avoid locking the package build directory when building with SwiftPM 6.

Additionally, I have an inflight PR to change --ignore-lock true to --ignore-lock so this commit will require a follow-up fix, after that change in SwiftPM is merged (swiftlang/swift-package-manager#7384).

SwiftPM 6 introduces a lock in the package build directory to avoid
concurrent builds/tests. Unfortuntely this behavior is needed by the
MMIOFileCheckTests currently. This commit adds a flag to avoid locking
the package build directory when building with SwiftPM 6.

Additionally, I have an inflight PR to change `--ignore-lock true` to
`--ignore-lock` so this commit will require a follow-up fix, after that
change in SwiftPM is merged (swiftlang/swift-package-manager#7384).
@rauhul
Copy link
Collaborator Author

rauhul commented Feb 29, 2024

@swift-ci test

@rauhul
Copy link
Collaborator Author

rauhul commented Feb 29, 2024

@swift-ci test

2 similar comments
@rauhul
Copy link
Collaborator Author

rauhul commented Mar 1, 2024

@swift-ci test

@rauhul
Copy link
Collaborator Author

rauhul commented Mar 3, 2024

@swift-ci test

@rauhul
Copy link
Collaborator Author

rauhul commented Mar 3, 2024

@swift-ci test

@rauhul rauhul merged commit 0e5a16f into main Mar 3, 2024
4 checks passed
@rauhul rauhul deleted the rauhul/swift-6-package-lock branch March 3, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant