Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of the _FoundationCollections toolchain module #395

Merged

Conversation

jmschonfeld
Copy link
Contributor

@jmschonfeld jmschonfeld commented Jun 25, 2024

The number of object files in the single _FoundationCollections toolchain module was causing issues on Windows by surpassing the maximum command line invocation length. To work around this for now, we reduce the size of the module by not including certain sub-modules. This will unblock the swift-foundation re-core work. At a later time, we could come back to adjust the CMake build to use response files to avoid a large command line invocation if necessary as a full solution.

Checklist

  • I've read the Contribution Guidelines
  • My contributions are licensed under the Swift license.
  • I've followed the coding style of the rest of the project.
  • I've added tests covering all new code paths my change adds to the project (if appropriate).
  • I've added benchmarks covering new functionality (if appropriate).
  • I've verified that my change does not break any existing tests or introduce unexplained benchmark regressions.
  • I've updated the documentation if necessary.

@jmschonfeld jmschonfeld force-pushed the reduce-foundation-module-size branch from d2bb146 to 36d5362 Compare June 26, 2024 16:51
@jmschonfeld jmschonfeld marked this pull request as ready for review June 26, 2024 16:52
@jmschonfeld jmschonfeld requested a review from lorentey as a code owner June 26, 2024 16:52
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reluctant thumbs up! Did enabling response files not work right?

@jmschonfeld
Copy link
Contributor Author

Spoke offline but unfortunately this was the simplest solution that unblocks the swift-foundation work at the moment, I wasn't able to immediately get the response files working but I'll followup to see if we can update to that approach in a later PR

@jmschonfeld jmschonfeld merged commit 3d2dc41 into apple:release/1.1 Jul 8, 2024
@jmschonfeld jmschonfeld deleted the reduce-foundation-module-size branch July 8, 2024 18:23
@lorentey lorentey added this to the 1.1.2 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants