Unify unsafe bit set implementations #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorentey
added
OrderedCollections
|
@swift-ci test |
|
@swift-ci test macOS platform |
CTMacUser
added a commit
to CTMacUser/swift-collections
that referenced
this pull request
Oct 10, 2023
commit 939cfd25234472b4dc91c3caeab304d15bca9a73
Merge: 9a85ee0 3f4d8f9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Apr 25 11:27:27 2023 -0700
Merge pull request #284 from lorentey/merge.release-1.1→main
Merge release/1.1 to main
commit 9a85ee0eec13ecb4143d91984cfd6aa55c514433
Merge: 33504bd 1f20455
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 24 17:37:00 2023 -0700
Merge pull request #282 from compnerd/compnerd/mainly-arm64
build: support ARM64 spelling
commit 3f4d8f9912c9c3f5bacef6e6543b3f5b93168f65
Merge: 33504bd 992e0f3
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 24 14:24:15 2023 -0700
Merge branch 'release/1.1' into 'main'
# Conflicts:
# Package.swift
commit 992e0f3446b4f608f5ead9dd6edc92f6bbc0b0a0
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 24 13:47:32 2023 -0700
Update configuration for the Swift Package Index
commit 3e4a8b4dff2b9d49ff1d99468647e443c8c59e2a
Merge: 2ca40e2 4cab1c1
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 24 13:44:24 2023 -0700
Merge branch 'release/1.0' into release/1.1
# Conflicts:
# .gitignore
# Package.swift
# Sources/Collections/Collections.docc/Collections.md
# Sources/Collections/Collections.docc/Extensions/Deque.md
# Sources/Collections/Collections.docc/Extensions/OrderedSet.UnorderedView.md
# Sources/Collections/Collections.docc/Extensions/OrderedSet.md
# Sources/DequeModule/DequeModule.docc/DequeModule.md
# Sources/DequeModule/DequeModule.docc/Extensions/Deque.md
# Sources/OrderedCollections/HashTable/_HashTable+UnsafeHandle.swift
# Sources/OrderedCollections/OrderedCollections.docc/Extensions/OrderedSet.UnorderedView.md
# Sources/OrderedCollections/OrderedCollections.docc/Extensions/OrderedSet.md
# Sources/OrderedCollections/OrderedCollections.docc/OrderedCollections.md
# Sources/OrderedCollections/OrderedDictionary/OrderedDictionary.swift
# Sources/OrderedCollections/OrderedSet/OrderedSet.swift
# Sources/OrderedCollections/Utilities/_UnsafeBitset.swift
# Utils/generate-docs.sh
commit 1f204555aa1678c0aa01cfba5836920acb8c5537
Author: Saleem Abdulrasool <abdulras@thebrowser.company>
Date: Thu Apr 13 10:14:40 2023 -0700
build: support ARM64 spelling
The Windows architecture spelling is ARM64 which we would not match and
thus would be unable to build for ARM64.
commit 2ca40e2a653e5e04a1c5468a35fc7494ef6db1d3
Merge: 9bb319f dce7b15
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 17 17:29:18 2023 -0700
Merge pull request #280 from lorentey/minor-rope-updates
[Rope] remove(at:): Fix assertion when removing the last item creates a deficiency
commit dce7b156e7276d44c3641f05bf675d90fea16523
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 17 17:20:07 2023 -0700
[Rope] remove(at:): Fix assertion when removing the last item creates a deficiency
commit 9bb319f3361248d3c0c775190f3ed01e32acb2b6
Merge: 84f51c2 b0fe7ca
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 17 12:08:03 2023 -0700
Merge pull request #279 from lorentey/minor-rope-updates
Minor rope updates
commit b0fe7ca8bad02599faa6a308b561f71d4d5e3b4b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Apr 14 14:38:30 2023 -0700
[Rope] replaceSubrange: take a sequence, not a collection
commit 8d7c630712109b02f7ab954f4defdb3366d86a72
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Apr 13 19:36:28 2023 -0700
[Xcode] Enable randomized testing
commit 3fa52c48de6955a9334e3ebb5b0f84827b228d20
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Apr 13 19:36:09 2023 -0700
[Rope] Add remove(at:), remove(at:in:) variants that preserve the position
commit 1925ed3001c53c8b337ac15f5fcba61f95910f76
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Apr 12 17:55:19 2023 -0700
[Rope] update(at:by:): Invalidate indices
Calling this function is supposed to invalidate all indices other than
the input index — so let’s do that.
commit cead2b3d647346672065b4f29ef440029f37b9a9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Apr 12 17:54:13 2023 -0700
[Rope] index(_:offsetBy:in:preferEnd:) fix result tuple labeling
This renames `remainder` to `remaining`, restoring API consistency.
commit bc21b90ff19d1b3d2a6c3145d5c8156d43ff8ee9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Apr 12 17:53:04 2023 -0700
[Rope] Minor usability fixes and API additions
commit 4afdfe4da269e1c57428c173e49c48228aeb382f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Apr 12 17:52:19 2023 -0700
[Rope] Flesh out docs a little bit
Rope remains woefully undocumented, and I suspect its abstraction
level isn’t right for general use, but let’s see if writing up some
documentation for it will make it a bit more accessible.
commit 84f51c2b9982f26f3dc4458c2ae55bf7109ec6b9
Merge: b727b93 99adbe9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 19:39:05 2023 -0700
Merge pull request #278 from lorentey/update-xcode-project
[Xcode] Update Xcode project
commit 99adbe97af48017fb51d884936f6bb87c27166c2
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 19:12:03 2023 -0700
[Xcode] Update Xcode project
- Update to Xcode 14.3
- Update source filelists
- Remove DEFINES_MODULE and related settings — this package does not define a clang module.
commit b727b93f9b20d7fb4d22b6054e497b258b1a6976
Merge: b36fbe6 a8dad62
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 18:45:31 2023 -0700
Merge pull request #277 from lorentey/remove-swift-5.5-checks
Remove obsolete swift(>=5.5)/swift(>=5.6) checks
commit b36fbe6ba8e8ffd5110c47b46f613766915fc580
Merge: 1ea846b ac0c075
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 18:45:05 2023 -0700
Merge pull request #276 from lorentey/hashcollections-lifetime-fixes
[HashCollections] Ensure `self` doesn’t get destroyed before we’re done working with it
commit a8dad62bc9c76f1f455a372c91759e7bb1e92e63
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 18:33:52 2023 -0700
Remove obsolete swift(>=5.5)/swift(>=5.6) checks
commit 33504bdc159d076c4a84ecf08941c9e648f9a11c
Merge: 53a8adc fef3839
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 18:26:25 2023 -0700
Merge pull request #254 from warpling/main
[OrderedDictionary] Explicitly mention in documentation that keys/values are ordered
commit ac0c075ccc0fe2754a41dd777bb39507e73efe5b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 18:24:33 2023 -0700
[HashCollections] Ensure `self` doesn’t get destroyed before we’re done working with it
The HashCollections module includes several mutating methods that dereference unmanaged references to internal nodes after the last usage of `self`. Prevent the compiler from destroying `self` before we’re done working within descendants of its tree.
commit 1ea846bcae413d34a7605265083feacf4c57861d
Merge: 26a7365 7f63914
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:45:21 2023 -0700
Merge pull request #275 from lorentey/ordereddictionary-doc-updates
[OrderedDictionary] Explicitly mention in documentation that keys/values are ordered
commit 26a73653b377cda2a2f5ae291c1b064c299f4333
Merge: 900e785 4b6978b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:43:36 2023 -0700
Merge pull request #273 from lorentey/require-5.6
Require Swift 5.6
commit 900e7851ab5d5ec42a49cf0fba8f0a336a097d24
Merge: 7c17b02 9c3328e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:43:23 2023 -0700
Merge pull request #271 from lorentey/fix-rope-sendable
Rope: Fix `Sendable` conformance
commit 4cab1c1c417855b90e9cfde40349a43aff99c536
Merge: 6b63044 26de4aa
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:43:08 2023 -0700
Merge pull request #268 from FelixHerrmann/release/1.0
Fix deprecated UnsafeMutablePointer.assign(repeating:count) method
commit 7c17b02963ef282d0218812e56bb5741ea9f0568
Merge: 64e940d 96d7162
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:42:39 2023 -0700
Merge pull request #272 from lorentey/fix-bigstring-utility
BigString: Fix String.Index._knownScalarAligned
commit 64e940d9ff6b6511bad8ab7b2280d18c3bf47e65
Merge: 8ca5c03 454c84b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:42:23 2023 -0700
Merge pull request #270 from lorentey/inlinable-ropes
Make most of Rope inlinable
commit 7f63914a7161923e9af6889ed0f954de1ed4c7f0
Author: Ryan McLeod <220240+warpling@users.noreply.github.com>
Date: Mon Dec 19 14:23:40 2022 +0100
[OrderedDictionary] Explicitly mention in documentation that keys/values are ordered
(cherry picked from commit fef38395004569688a967b88c70d8774c63f5fc5)
commit 8ca5c0367f5d77662187570ed8d01d613cd67036
Merge: 83bc546 3e6df33
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:32:10 2023 -0700
Merge pull request #263 from lorentey/bitcollections-finalization
BitArray API refinements & additions
commit 4b6978bf8b220c9c7d03d1f8124d537fbbddc32a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 17:06:33 2023 -0700
Require Swift 5.6
Swift 5.8 is out now, so let’s bump the minimum required toolchain to Swift 5.6. (The package wants to support three major language releases, and now that 5.8 is out, supporting 5.5 would bump that to four.)
commit 454c84b5e4253e462dac5472b853ee222ca93368
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 16:41:17 2023 -0700
Make most of Rope inlinable
commit 96d71628887275fc3010a0979cdebef15edde911
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 16:49:29 2023 -0700
BigString: Fix String.Index._knownScalarAligned
This member isn’t currently used, but unlike its counterpart in the stdlib, this one accidentally sets the character-alignment bit.
commit 9c3328e235e5f17c06328f021a5d11e7221690f5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 16:45:28 2023 -0700
Rope: Fix Sendable conformance
`Rope._Node` wasn’t declared `Sendable`, which triggered valid warnings.
commit 83bc546471de9583b52c767742cb008ff70474f8
Merge: c81f73f 73936bb
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Apr 10 12:17:42 2023 -0700
Merge pull request #269 from lorentey/expose-BigString-Index-methods
Expose a handful of BigString.Index methods
commit 73936bba69bd49e025aa8113fa81caa7f76ed571
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Apr 7 19:21:44 2023 -0700
Expose a handful of BigString.Index methods
These help implementing conversions between String.Index and BigString.Index.
commit 26de4aa094c87a9efd793f3ec37ec7facea24184
Author: Felix Herrmann <felix.herrmann@icloud.com>
Date: Wed Mar 29 19:05:43 2023 +0200
Fix deprecated UnsafeMutablePointer.assign(repeating:count) method
commit c81f73f05a07e3aabfbb8d8d4802deb7ebf2cae8
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 23 16:27:05 2023 -0700
Move build settings from Xcode project into xcconfig files
commit a0666cdcce8a3ee3054b38570765fb691411b199
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 23 14:23:45 2023 -0700
Resolve some leftover build issues
commit 3cbf81976d799b010b8d0f51f430bd211ccb2e7c
Merge: e0e5abb 1666222
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 23 13:54:45 2023 -0700
Merge pull request #266 from lorentey/monomodule-support
Monomodule support
commit 1666222de2200b2a614a0d5184751b8b6f7309b0
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 23 13:43:01 2023 -0700
Add READMEs calling out the fact that the contents of Tests/, Utils/ & Xcode/ are unstable
commit 0a55894501275f4e75a38fd186cea4a6dd242b7c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 23 13:04:41 2023 -0700
Add an Xcode project exercising a monomodule configuration
This is going to ship as is, with no promises about it remaining in future versions. It is going to be a load bearing component of the package, though — just not necessary a stable one.
commit 8a4c842ad391113d12971e93d4cbba6d2674f5ca
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 22:04:47 2023 -0700
Disable COLLECTIONS_SINGLE_MODULE by default
Also, remove COLLECTIONS_ENABLE_UNSTABLE_MODULES as it is no longer doing anything.
commit e0e5abbcc7fdf0fb24a3f983c8bfeef996ff4553
Merge: 9151af9 e6ecdac
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 21:55:35 2023 -0700
Merge pull request #267 from lorentey/fix-bitset
Fix off by one error in BitSet
commit e6ecdac581c3f03f442111b87655702e0664df67
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 21:45:46 2023 -0700
Fix off by one error in BitSet
commit f17cf642c1eb200f46c0535b9300a53503c1a7e5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 21:44:23 2023 -0700
Add support building with COLLECTIONS_SINGLE_MODULE
- Sources/_CollectionsTestSupport → Tests/_CollectionsTestSupport
- Refactor Package.swift to allow switching between the default
polymodule and the new monomodule product configurations
(by editing the manifest file).
- Fix build errors in the monomodule variant.
commit 2453c1bc23a44e0ead3bfcb6576091b335c4906d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 20:01:23 2023 -0700
Also generate @usableFromInline attributes, as needed
commit c287334a9b77841eb17c7bc8ce6cc4297734c4b7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 18:56:05 2023 -0700
_CollectionsUtilities: Use gyb to allow defining these helpers as internal or public depending on COLLECTIONS_SINGLE_MODULE
This is a thoroughly disgusting solution, but needs must. 😞
Hopefully macros will let us eventually replace this mess.
commit 688dbdf5c791689f7cb7056b61f7e40a8c670b1f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 22 18:14:00 2023 -0700
Add gyb 😞
commit e1ef053615ad20fb518fabb47c9c097d0eb82d83
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 18:46:10 2023 -0700
Stop mentioning the enclosing module’s name
commit ea60d293b4635e2a9d560251752ebb950959b113
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 18:43:46 2023 -0700
Fix test issues with single-module variant
commit cbab9e3737241d89cbec63a7ae04d89bb618870c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 17:20:33 2023 -0700
Introduce COLLECTIONS_SINGLE_MODULE condition
commit cc181a3bce5a14d51e5b388f7c1e44245b0a9438
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 16:39:03 2023 -0700
HeapModule: _Node → _HeapNode
This makes this name unique throughout the package, allowing this code to be built as a single, huge module.
commit 424c8ece985ea6e6ec2a578a075b5e58ebe86d21
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 16:37:22 2023 -0700
HashTreeCollections: Qualify internal type names with “Hash”
This makes them unique throughout the package, allowing this code to be built as a single, huge module.
commit 9151af9fa89e4239717bce33abac5d44ce3b6a79
Merge: 8c7b853 fcd6800
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 11:52:09 2023 -0700
Merge pull request #264 from lorentey/ropes
Add not so experimental rope implementation
commit fcd6800b9d1171fbe0a00f51a72afac32b0a1987
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 11:42:56 2023 -0700
BigString: Slightly speed up a slow test
commit 8394ea7575b996a4dabc5be75eaca9fed85227b7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 01:30:03 2023 -0700
Clean up test definitions
commit 28010b2f6c481b766a8ba0150541b3f9b8dae840
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 01:28:13 2023 -0700
Use COLLECTIONS_INTERNAL_CHECKS
commit ad82bc3f805a2124d475bd0e36e175f024f049f3
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 01:21:43 2023 -0700
Naming review
commit dc23b4d621b8a929ea0413fb250d5cf096d2c949
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 01:06:53 2023 -0700
Rope: Fix splitting logic after insertions
I changed the minNodeSize formula to match with the B-tree definition, but I failed to match the insertion logic, so it left trees with undersized nodes. D’oh!
commit 88286b661d30291e827f8842b68aabe163083820
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 21 00:35:08 2023 -0700
BigString: Fix Issue in utf16.distance when endpoint is on the trailing surrogate of the first scalar in a chunk
commit 6f3f19d1c50cfa32970a3e5ec897ceb866564b32
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 23:48:07 2023 -0700
_Rope → Rope
commit 51ef8613c2058c7a35e7da7c27a1c4d48e6ab8b2
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 22:27:32 2023 -0700
Underscore more internals
commit 0ad7f0ce38c5b6edaafdee3ae466905eacd5e90f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 20:57:20 2023 -0700
_BString → BigString
commit 706be4d9dfe888c37bb59825a87b3193ee39668a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 19:54:44 2023 -0700
Also, don’t forget to call super.setUp
commit 24e58e86fc4dee200009fa2dc739d15189c85c26
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 19:49:42 2023 -0700
Don’t override `XCTestCase.invokeTest` on non-Darwin systems
commit 44cff407127a6ecce70a88a9ef2767679282f173
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 19:34:52 2023 -0700
Work around SPM limitations around test case availability 💗
commit b022b7fee5f0e383d9f80c70b253f58196142963
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 18:31:14 2023 -0700
Make _BString and _Rope public
commit 73de433eef93d860176819a5b29ffea1fa565530
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 16:40:37 2023 -0700
Restore workaround for SR-14663
commit 09577a31eef03c39a5b8ca2bc0bf9461985c8697
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 16:40:08 2023 -0700
RopeModule→_RopeModule. Stop reexporting it from Collections.
This module is not source stable; mark it as such by prepending
the module name with an underscore.
commit 79f1e16afd2c5e0b727eec161044107aff5b19d7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 16:38:38 2023 -0700
Don’t skip building/testing BitCollections and HeapModule
commit 975a8902ffaf3aff0c2a298ba7f6514b134cc7d1
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 15:26:11 2023 -0700
Disable modules that haven’t gone through API review yet
These are disabled on the package manifest level.
To locally reenable them, Package.swift needs to be manually edited to enable COLLECTIONS_ENABLE_UNSTABLE_MODULES.
To mark a module as ready for production use, it has to be defined using `registerLibrary` instead of `registerUnstableLibrary`. This can only be done once the module has gone through API review. (Or if it becomes an underscored — i.e., explicitly unstable — module.)
commit 535b8b8562da59b478fb02c9c5453f6fc5fc2326
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 20 14:25:28 2023 -0700
Fix compatbility with Swift toolchains below 5.8
commit ddcd1788aa6d1d973ade0a2d0df9861254c7d40f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 16 11:24:55 2023 -0700
Unconditionally enable use of _CharacterRecognizer’s Equatable conformance if we aren’t building a package
commit 4849d546758a25b9d4bd4a812009212ca0db9d7d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 16 11:09:46 2023 -0700
Add a compile-time conditional for enabling randomized testing, enabled by default
commit da78365bef8e88e6952827ddc48530cacd16a60e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 16 11:08:31 2023 -0700
_BString: Add isIdentical(to:) to all string views
commit b50fb5aab5fe1e2ddec021bafdfed377ad1c57df
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 14 16:14:44 2023 -0700
_BString.resolve: Don’t crash when resolving indices in the empty string
commit 64a8098bf9a9da15986368358ef6a87e37f95ca5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 13 20:35:42 2023 -0700
_BSubstring.UnicodeScalarView: Fix range-replacing mutations that don’t take indices
commit b355480eb7fe1f1c8737f8bb4654305a3858ad65
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 13 20:34:48 2023 -0700
_BString: Make unicodeScalars properties mutable
commit b8927d819b2b712c9edc7d5f9a8ba83d43dd9db7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 13 18:49:52 2023 -0700
BigString: Flesh out views, make them consistent with _BString
commit d79a752fc86a03c353537dc2964959ac7198c37c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 13 18:49:12 2023 -0700
_BString: Review views & add missing functionality/shortcuts
commit 033bf17f9d8e96f673fe633463fc386a824e2529
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 13 13:54:15 2023 -0700
_BString: Add UTF-8 and UTF-16 index rounding tests
UTF-16 index rounding is a semantic mess; the behavior is emulating
the stdlib, and it seems far more useful than if we went with a
semantically consistent definition.
commit 22113290f1eea1fea51cb15e2f487d440c019528
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 20:18:13 2023 -0800
_BString: Adjust substring mutation test to actually exercise Unicode weirdness
commit cffcd517a2c471bf9fa8ded3cbcd00389f69abaf
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 20:17:32 2023 -0800
BigString: Start modernizing
commit 6a7f53c3da992cdb03097c0b7cc149fc4be4e123
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 20:17:00 2023 -0800
_BString: Add conversion initializers from all views
commit 05f8f9b8876d0f12efe3b7d0d5d7d96761f96031
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 19:27:06 2023 -0800
_BString: Modernize tests
commit 03d7c43c22760aea7df7e96f18ee31ffd778a638
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 19:26:43 2023 -0800
_BString: Add index rounding methods to all views
commit 258d22947c90574c4b734d0258d0d13de5a3ff86
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 19:13:47 2023 -0800
_BString: Review Equatable implementations
commit abf5dfd260209dc550a826d745a2a03bde6ddcab
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 18:55:27 2023 -0800
_BSubstring: Conform to Comparable
commit 118239806868f4700e2098bb77f95ae5c06fe6ac
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 18:49:48 2023 -0800
_BString: Give each view a custom iterator by hooking up the existing implementations
commit 59b5c634d00f1eb95704282bd6f1df95c6582d5f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 18:00:14 2023 -0800
_Rope.UnsafeHandle._removeChild(at:): Fix buffer overflow uncovered by ASan
commit a10439bc324c9e5aca8fdbb19946ebe9af14eb75
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Mar 10 17:58:20 2023 -0800
_BString, _BSubstring: Merge character views into top-level types. Add RangeReplaceableCollection conformances.
This emulates the standard String.
commit eda72e344f2604e6b85158a995a8b4c0bdcec879
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 8 18:44:39 2023 -0800
_BString: Fix character index rounding; use it when accessing character data
Oops, `_BString.subscript(character:)` failed to round down to a character boundary before trying to access the addressed character. It also resolved the index with `preferEnd` set to true, which isn’t what we actually want.
commit e0f8305a99d8c9ec7cfbf5f8cba52993932f0d18
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Mar 8 15:51:13 2023 -0800
_BString.hashUTF8(into:from:end:): Fix typo
- The original code accidentally used `start` instead of `end` to normalize the end of the range, so it did not actually hash any actual string contents.
- While we’re here, extract the task of iterating over substring chunks into a reusable standalone method.
commit 28727f7c56bed67562a0d8471b207e45275a5101
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 6 19:03:55 2023 -0800
_BString: Implement views
Having all core functionality exposed by the top-level type is not a bad idea; unfortunately substrings are tricky to get right, so it’s better to implement that out of the box.
commit b5e3bee275c0dd27532fde3791c8c67c51bc8cd1
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 6 16:39:06 2023 -0800
_BString.Index: Add alignment bits
Use them to speed up index rounding.
(And, somewhat questionably, subscripting.)
commit 7444bb24cb053f506f56c7891058155dfeb53250
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Mar 6 13:04:29 2023 -0800
_CharacterRecognizer don’t use conformances that aren’t in the Xcode 14.3 beta
commit 4f2024c44d9dcd718b5d34b23e9b5b5a4f49ab50
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 2 18:32:07 2023 -0800
_BString: Elaborate on the swift 5.8 dependency a bit
commit 85a43d9ac6c9948eee7215f293dd4b9747958c9e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Mar 2 16:28:23 2023 -0800
_BString: Add a substring types and actual collection views
This is more of a technical workaround, as it allows
running generic algorithms on these things. That said,
we could embrace this in general, and sink the
`utf8Index(after:)`, `characterIndex(before:)` etc
function down into these views, instead of having them
on the top level.
commit fe54fdaa47f36da6e7012b33c718d876724f8e72
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Feb 28 15:28:13 2023 -0800
More fixes.
commit 605e45b9b94948ba557b62a25e55453444e136bb
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Feb 28 14:22:43 2023 -0800
_BString: Additional fixes and new functionality
- New methods for rounding up indices
- Sendable conformances
- Fix UTF-16 strings sometimes leaking into chunks
- Iterator improvements / rewrites, incl. a chunked UTF-8
buffer iterator.
- Support for comparing and hashing UTF-8 slices.
commit 9bbdfdc49791d59233e24e3694c8007ae4ced496
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Feb 21 17:19:48 2023 -0800
Cosmetic updates to _BString.CharacterIterator
commit 79bdcb66eb3154f7c96ac15a97be08ee3703cc2d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Feb 21 16:50:13 2023 -0800
Implement path caching in indices
commit 575937f6ff1011efddc9aba2ab5b2bbde0c51d97
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Feb 20 17:00:59 2023 -0800
Remove _Rope._leaf(at:)
commit b6f9d83c608f1040c8deea1e84cef35d34615ebb
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Feb 20 16:50:14 2023 -0800
Replace Rope iterator with indices in most index-like use cases
commit 3cc5a3888abc39bdf5bc4add2ec4ea8d8fb3e2fd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Feb 20 14:47:29 2023 -0800
_Rope: Add a leaf node reference to indices. Implement explicit index invalidation
commit 8f48c3ae37b4e9241bcb0c07a4376cbde9f5c22e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Feb 16 11:00:14 2023 -0800
More assorted bug fixes and refinements
commit 8c1740ad283caff01de9387e5592bd0aee8c6efd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Feb 13 11:00:38 2023 -0800
_Rope.Index: Merge height into UInt64 storage.
This leaves 56 bits for path data, which should still be plenty.
(We want to allow big strings to grow to 2^48 UTF-8 code units, to
match the standard String; however, there is no practical need to
support any more, and even that is a stretch.)
Add tests to verify that the tree capacity matches expectations
in Release builds. (In Debug builds, we limit the maximum node size,
which drastically reduces capacity. This is okay.)
commit 67a149da6a3dcfd335d10bb026d85e5e91684db2
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Feb 13 10:55:51 2023 -0800
_BString: Set better max node size in Release builds
Also, adjust minimum node size calculation to match classic B-trees.
commit 8c8cb5622bf62576a4fb435bddb98c363cfa1f1d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Feb 9 14:35:27 2023 -0800
Restrict BIgString and _BString to Swift 5.8 and macOS 13.3 /iOS 16.4/etc
These types heavily rely on stdlib functionality that ships in
Swift 5.8; they do not run correctly on earlier releases.
commit 283d4071bcf1705850b43ab001265673682abe8f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Feb 9 14:33:36 2023 -0800
Assorted bug fixes and refinements
commit 96aebb90b74791ea5d6b9377653d84c1e9ef226b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Feb 3 18:35:48 2023 -0800
Fix initializing a String from a _BString slice
commit 18aa309f758a889ab78a88debd9f6b9eab169267
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Feb 3 18:35:24 2023 -0800
Generalize some _BString iterators
commit eabd9417991fee880a566951c223a0adcaf0832b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Feb 1 00:09:44 2023 -0800
Add some operations taking subsequences
commit 150a165d73f0a8b31b9a8280b4d429640f725679
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 18:27:52 2023 -0800
Add experimental rope implementation
commit 6b63044bb9178fa43a602ffdf6c19d7ef56468a6
Merge: 937e904 5dc7a89
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Mar 14 17:28:15 2023 -0700
Merge pull request #265 from compnerd/arm64
build: add ARM64 to the architecture mappings for Windows
commit 5dc7a8970eabcf6aaa49529b5ef6401f5128637e
Author: Saleem Abdulrasool <abdulras@thebrowser.company>
Date: Thu Mar 2 10:59:03 2023 -0800
build: add ARM64 to the architecture mappings for Windows
Windows uses `ARM64` for `CMAKE_SYSTEM_PROCESSOR` which does not match
the current spellings.
commit 3e6df33472d54ed83dffe3bca7a3c8f65bab4c43
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 18:04:41 2023 -0800
[BitArray] Update tests
commit a360969ec6ec8dd0ce8d65dbcdca3be6bb444a34
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 18:04:30 2023 -0800
[BitArray] Add masking and resizing shifts
commit 866d00798f6c802bc7c70244d8f7766c933ed566
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 18:02:16 2023 -0800
[BitArray] Add LosslessStringConvertible conformance
commit 17343b752a208b8545dbec998cd71a465a54bde4
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 18:01:46 2023 -0800
[BitArray] fill(in:with:), insert(repeating:count:at:), append(repeating:count:)
commit a90b73966ae43f4c92ae2d5ec0deeb12c46c9499
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 18:00:27 2023 -0800
[BitArray] Add conformance to ExpressibleByStringLiteral
commit a8bde6343976f70ce5043516f474fcd17bb52dac
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 17:59:56 2023 -0800
[BitArray] Add toggleAll(), toggleAll(in:)
commit c15b0d9889ef065ba1f6c9b33ae5cc057fd03ff6
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 17:59:24 2023 -0800
[BitArray] Add BitArray → BinaryInteger conversion initializers
extension BinaryInteger {
public init(truncatingIfNeeded source: BitArray)
public init?(exactly source: BitArray)
public init(_ source: BitArray)
}
commit c15e484f5aa2a404daa36bcb71b487433cc02885
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 17:43:06 2023 -0800
[BitArray] Add init(minimumCapacity:)
commit 4281dc4482114d17727f1c1cd7a6f3a8690bdf0e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 17:39:46 2023 -0800
[BitArray] Change description to print bit arrays as binary numerals
This matches std::bitset, and it seems to be the more logical option.
commit 03b62ffb6e80d4514a86645c2858c5d7bc21cfb9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 17:33:05 2023 -0800
[BitArray] random(count:using:) → randomBits(count:using:)
commit 6cb03fee98a3065f938c269fc2c5340a8e262f9f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Jan 31 17:30:39 2023 -0800
[BitCollections] Update file headers
commit fef38395004569688a967b88c70d8774c63f5fc5
Author: Ryan McLeod <220240+warpling@users.noreply.github.com>
Date: Mon Dec 19 14:23:40 2022 +0100
[OrderedDictionary] Explicitly mention in documentation that keys/values are ordered
commit 937e904258d22af6e447a0b72c0bc67583ef64a2
Merge: 08e91c6 089666b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Dec 8 10:54:21 2022 -0800
Merge pull request #252 from lorentey/add-documentation-bundles
[1.0] Add DocC documentation bundles
commit 089666b32ba82c06a166e072ebcdf988108b66b7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Dec 7 14:25:12 2022 -0800
Add a separate package manifest for Swift 5.5+
commit b4c1070741a119654864b736268c3f03f6799a1b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 21:02:34 2022 -0800
[Docs] Update high-level Collections docs
commit e14a0359ca4aeee4e9ceb5339592a1dbce9a7289
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 21:02:09 2022 -0800
Add a configuration file for the Swift Package Index
commit 847b548a03c8db491150820e0b97cdf286b4a3fe
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 19:39:08 2022 -0800
[Manifest] Exclude documentation bundles from 5.3 manifest
We should have a separate Package@swift-5.5.swift manifest
that removes these exclusions; however, that requires some
additional validation testing — let’s do that later.
commit a874de5f7f7c95d1a439169f10a4b0289a936627
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 19:00:59 2022 -0800
[OrderedCollections] Refresh some docs with DocC links
commit 08b38129b9d2b584d7447d79ce7a00867d601410
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 18:41:29 2022 -0800
[OrderedSet] Fix outdated documentation
commit 141c3939bf9e792e6add1aaa8faddf007c36dc7f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 18:41:04 2022 -0800
[DocC] Add documentation bundles for all three targets
commit 53a8adc54374f620002a3b6401d39e0feb3c57ae
Merge: ceab2a5 c0853eb
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 18:10:41 2022 -0800
Merge pull request #251 from apple/glessard-patch-1
Update README.md
commit c0853ebef8dad7eddb6a44b76dac0f42f699b96a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Dec 6 16:44:06 2022 -0800
Create README.md
commit 3b1e3900fc36326800c1ec288dbc4c6382a60411
Author: Guillaume Lessard <glessard@users.noreply.github.com>
Date: Tue Dec 6 16:26:15 2022 -0800
Update README.md
commit a34c754dc6376156d7168708490e8dfc9867057e
Author: Guillaume Lessard <glessard@users.noreply.github.com>
Date: Tue Dec 6 16:26:07 2022 -0800
Update README.md
commit e7da68df5b78fbfcee4f34ec80ecd164ad61cbdc
Author: Guillaume Lessard <glessard@users.noreply.github.com>
Date: Tue Dec 6 16:19:05 2022 -0800
Update README.md
Try to clarify the state of `BitSet`, `BitArray` and `Heap`
commit ceab2a560af75361d0f6ca01a15ad58174daf77e
Merge: 0d4b9e3 10a01bd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 17:10:39 2022 -0800
Merge pull request #248 from lorentey/merge-1.1→main
Merge branch `release/1.1` to `main`
commit 10a01bd9fb383668a987ec8f512da627dbe55f9e
Merge: 0d4b9e3 8c7b853
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 16:36:22 2022 -0800
Merge branch 'release/1.1'
# Conflicts:
# Package.swift
commit 8c7b8536ea0d21faeeb05229aa7537e9e2636794
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 16:33:42 2022 -0800
[cmake] Update CMake configuration
commit 531d2e60e60d3c9b512601dc79fe1e8746a3e3db
Merge: edc166e b8ed495
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 16:15:47 2022 -0800
Merge pull request #247 from lorentey/fix-TreeDictionary-merge
[TreeDictionary] Fix in-place merge operation to properly update the count
commit b8ed4950368d4d54cefd2b8bfe14c329e057172c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 14:37:56 2022 -0800
[TreeDictionary] Add some more missing _invariantCheck calls, for good measure
commit c59ea2ad518b58c49cf6f0a1d6daac5dbae3cfcd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 14:30:25 2022 -0800
[TreeDictionary] merge: Update counts properly
commit 5b37259155e91f01f35fe0d18d6d5eef8d15bcb1
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 14:29:53 2022 -0800
[TreeDictionary] merge: Add missing invariant checks
The lack of these calls allowed our tests to pass even though the
implementation is failing to properly update the count. D’oh!
This and the previous commits adds a myriad new test failures.
commit a6392bf57819a24c9538a22bb8f15463bd8a0ed6
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 30 14:27:47 2022 -0800
[test] expectEqualDictionaries: Also compare counts, as a fallback in case of missing invariant checks
commit edc166e97946b745a3325febb6ee79bed7aeee9d
Merge: aeac065 3d66da5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 28 23:36:21 2022 -0800
Merge pull request #242 from lorentey/HashTreeCollections
commit aeac06544ed5ae7e5c66bd1ff5c8fa039c2c73e2
Merge: 8cc18a2 69768b6
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 28 22:06:07 2022 -0800
Merge pull request #245 from lorentey/unify-unsafe-bitsets
Fix warnings in development versions of Swift
commit 69768b6eacd442681bc8424cc76516e7e24fdacc
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 28 21:51:57 2022 -0800
[OrderedCollections, BitCollections] Fix more warnings in development versions of Swift
commit 3d66da5f5baa3585aa4b5fe8f9d9eaaee5e5a6ef
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Nov 15 15:08:50 2022 -0800
[Xcode] Adjust scheme for Collections module
commit 24adfd8f29fbdc12ccb196fdad5ae399c1aa458a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Nov 15 14:50:57 2022 -0800
[HashTreeCollections] Update links in docs
commit b8ef14f0c05fd81f0a3f146a536753ff95505aea
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Nov 15 14:27:11 2022 -0800
ShareableHashedCollections → HashTreeCollections
commit 8cc18a2fe5bb6b4d7aca27cd01b86cf88c3ca731
Merge: d1f1ab0 a2f4b18
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 28 21:33:11 2022 -0800
Merge pull request #244 from lorentey/unify-unsafe-bitsets
Unify unsafe bit set implementations
commit d1f1ab0808af28bebf8bd6ef235421d5cd0c172d
Merge: c80b844 2c33149
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 28 17:36:11 2022 -0800
Merge pull request #243 from lorentey/fix-missing-import
[ShareableHashedCollections] Add missing import
commit a2f4b18ae02cd14a8488c357c75fef3f2c2a9013
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 28 16:30:55 2022 -0800
[BitSet, OrderedCollections] Unify UnsafeBitSet implementations
commit 2c33149e4e2cb9a5b2616cdbad9eabb5f51f0e0c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 23 15:45:14 2022 -0800
[ShareableHashedCollections] Add missing import
commit 0d4b9e3346eb0373ac6f85fe799b44b9b7e86d7e
Merge: efe7ae9 18c4f6d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Nov 15 15:48:21 2022 -0800
Merge pull request #241 from nickkohrn/patch-1
[Hashtable] Minor Documentation Fix (Typo)
commit 18c4f6dc5a771cd3f90ef3e7ae02a99e09e89115
Author: Nick Kohrn <nickkohrn@users.noreply.github.com>
Date: Sat Nov 12 21:49:19 2022 -0500
[Hashtable] Minor documentation fix (typo)
commit c80b844e5eca9c6b9f0a726f6e75262933b76167
Merge: b66cf9e ff85ea9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Nov 10 11:33:15 2022 -0800
Merge pull request #240 from lorentey/fix-benchmark-libraries
[Benchmarks] Split default huge library up into individual files, one per type
commit ff85ea9e4f1cf6fd50fb758cde3dedf01a742f52
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 9 19:26:47 2022 -0800
[Benchmarks] Split default huge library up into individual files, one per type
commit b66cf9e4d29dac93d06a61669dbfaa275787746b
Merge: 94cb3b6 339f167
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Nov 9 18:35:36 2022 -0800
Merge pull request #238 from lorentey/ShareableHashedCollections
[ShareableHashedCollections] API Review: add missing `mutating` keywords
commit 339f1677450d7a8f43518d61cfd93be85fa080c3
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 18:53:07 2022 -0800
[ShareableHashedCollections] API Review: add missing `mutating` keywords
commit 94cb3b6792397476cd71eb6f34920577dee03f79
Merge: ff56114 98d519e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 18:44:55 2022 -0800
Merge pull request #237 from lorentey/ShareableHashedCollections
Apply changes from in-progress review thread
commit 98d519ec12ec6bc209ad61fed2e7e2101e312566
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 18:26:38 2022 -0800
[ShareableHashedCollections] Update link in API review document
commit 9f858929b45724e606f2cf6df2c7ddf7418a3497
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 18:18:40 2022 -0800
[ShareableHashedCollections] Remove fluent operations
commit bab7b7a37386e979fec5a033819adc5013557cac
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 18:10:11 2022 -0800
[ShareableHashedCollections] Update API review document
commit b985c6bc1d8064ffe2bb0c753bf6bb55dddd85a5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 17:31:58 2022 -0800
[Benchmarks] Update/fix ShareableSet benchmarks
commit d9861ab322f0a67548b8650f651c5d74c7fd3662
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Nov 7 14:14:24 2022 -0800
[ShareableDictionary] Add removeAll(where:)
commit b3884de3321c6cb2f9206356619337a90379dfbf
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 14:26:26 2022 -0800
[ShareableHashedCollections] Update DocC links 🙄
Also, put `removeAll(where:)` in the right category
commit e8fc3ee4cdce8905fa6721ae4fef029176672ca0
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 14:10:38 2022 -0800
[PersistentCollections] Rename to SharableHashedCollections
`PersistentSet` → `ShareableSet`
`PersistentDictionary` → `ShareableDictionary`
`PersistentCollections` → `ShareableHashedCollections`
commit 1098c526545f396502ad7f7e05fd4ee871076639
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 13:41:36 2022 -0800
Add API review proposal for PersistentCollections
commit 84e324dc45d80a26e11b2a22cefddfba85ff1512
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 13:20:50 2022 -0800
[Benchmarks] Add the model diffing tasks to the PersistentSet library
commit a7411c59bcaf40738cd70cf3b433ae4ec5157553
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 13:18:22 2022 -0800
[PersistentSet] Add removeAll(where:)
commit 80195a8374da3b1acdec7cb993d972459fd1ec2d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 12:31:16 2022 -0800
[PersistentSet] Add fixmes for in-place reductions
commit 9a92eaeac34bab44b56d8c44a5b2789478cf1bc8
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sun Nov 6 12:30:43 2022 -0800
[PersistentSet] Clarify note on isEqualSet
commit ff561141d8aff2eaca3dc8952797e97c7130cfae
Merge: 0e230a9 ff2d526
Author: Karoy Lorentey <klorentey@apple.com>
Date: Tue Nov 1 11:06:47 2022 -0700
Merge pull request #235 from lorentey/PersistentCollections-review-prep
[PersistentCollections] Doc & benchmark updates in preparation of API review
commit ff2d526c1baa53df478db47156bbdd68fcaed4df
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 17:27:49 2022 -0700
[PersistentDictionary] Doc fixes
commit 7d0d627f444139aed9d31ef3b0018c085a7251da
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 17:20:15 2022 -0700
[PersistentSet] Fix doc typo
commit 898d3c9a517a4511cdaaeeeb329fd8cc6b8de156
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 16:45:11 2022 -0700
[PersistentCollections] Doc & benchmark updates in preparation of API review
commit 0e230a95fbef3fba78b692bef36d3a71e075cc7d
Merge: 1b53fc8 581490a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 16:44:51 2022 -0700
Merge pull request #234 from lorentey/fix-isEqual-naming
[SetAlgebra types] isEqual(to:) → isEqualSet(to:)
commit 581490a7351be07e465100628ded472aaa137a99
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 15:10:11 2022 -0700
[CMake] Update CMakeLists.txts
commit 8f7d5fd50532e883a3d59e050a17ec992827fef8
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 15:05:12 2022 -0700
[SetAlgebra types] isEqual(to:) → isEqualSet(to:)
The `isEqual(to:)` methods are a bit too confusing — they implement
mathematical set comparisons (ignoring element ordering and, in the
case of the Sequence variant, even element multiplicities), so it
seems better to highlight this by putting a `Set` in the name.
commit efe7ae9206d867ec98f21655c31945dd19ae7976
Merge: ec39868 4448454
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 14:36:09 2022 -0700
Merge pull request #232 from lorentey/SortedCollections-disable-debug-tests
[SortedCollections] Disable tests with @testable imports in release builds
commit 1b53fc88d5b73a4e093a995f428bf95a0d1f299f
Merge: 5e80c92 14e86da
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 14:35:57 2022 -0700
Merge pull request #233 from lorentey/PersistentSet-iterator-fix
[PersistentSet] Iterator.next(): Make inlinable
commit 14e86daeebe18bd32466a1f2bd2d8da936aa6508
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 14:03:49 2022 -0700
[PersistentSet] Iterator.next(): Make inlinable
For a cool 4x performance improvement. 😣
commit 4448454fbc79b8052acc6b6e7eb6c75c70d1ee2f
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 14:02:30 2022 -0700
[SortedCollections] Disable tests with @testable imports in release builds
commit ec39868194fae4a5c0310c4b9ad7ccf2d4d3f2d2
Merge: 4196e65 a32048d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 31 12:36:34 2022 -0700
Merge pull request #231 from lorentey/merge-release-1.1→main
Merge branch release/1.1 to main
commit a32048d44ee028b915565c3093ec5305e41aa6f1
Merge: 4196e65 5e80c92
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 18:21:18 2022 -0700
Merge branch 'release/1.1' to ‘main’
commit 5e80c929417ac4eff951010704ed91c7f414906e
Merge: f649303 d19fb14
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 18:20:21 2022 -0700
Merge pull request #230 from lorentey/update-cmake
Update CMake build configuration
commit d19fb14c46266a20cba9c5362923c6a076e74407
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 18:18:39 2022 -0700
[CMake] Update CMake configuration
commit f649303db14623b7d03bf9cc427c872e2d9444c1
Merge: bef610f 1c147e3
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 18:05:49 2022 -0700
Merge pull request #228 from lorentey/DocC
Start working on DocC support
commit 1c147e3b06edbe0b00217e38e94d2d3bc4b4c6a7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 12:35:37 2022 -0700
[Collections] Regenerate docs
commit aaeeb9e440e4253f3148540dd02df4e434ed31c0
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 17:13:44 2022 -0700
[OrderedCollections] Doc updates
commit b2f254384dcb40c2c293e226093ce7dadbec2ee4
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:06:09 2022 -0700
[doc] Add some flesh to DocC structure
# Conflicts:
# Sources/BitCollections/BitCollections.docc/Extensions/BitArray.md
# Sources/BitCollections/BitCollections.docc/Extensions/BitSet.Counted.md
# Sources/BitCollections/BitCollections.docc/Extensions/BitSet.md
# Sources/OrderedCollections/OrderedCollections.docc/Extensions/OrderedSet.UnorderedView.md
# Sources/OrderedCollections/OrderedCollections.docc/Extensions/OrderedSet.md
commit 6af8954d5b9c2937480d35d58a104fbd5229b272
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:04:51 2022 -0700
[doc] Add generate-docs.sh
commit 0120dd1d7946f769f7115577fa29c7dc6e141cf4
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:22:54 2022 -0700
[BitCollections] Categorize member APIs
commit de22bed429ed0c55c699ca3c1957535da15a6f65
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:20:37 2022 -0700
[OrderedCollections] Update top-level docs
commit 86bce288358754a07d87dd67a77addf095aaa03d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:19:10 2022 -0700
[docs] Start working on DocC support
commit bef610feb85792aa9cbaefb52f9394484150fdc2
Merge: a9fd8af 98d62d2
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 12:32:57 2022 -0700
Merge pull request #224 from lorentey/finalize-PersistentCollections
Finalize persistent collections API
commit a9fd8af8304654d75984107fbf406336292a58ab
Merge: d2099dd ba7e392
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 12:20:49 2022 -0700
Merge pull request #225 from lorentey/fix-custom-mirrors
[OrderedSet, BitSet] Fix custom mirror display style
commit 98d62d236bef8c30af5b7015ccbb7db66f43399e
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 12:19:08 2022 -0700
[PersistentDictionary] More keys diffing APIs; additional documentation & testing
commit ba7e3927e76ff55b0579770fb036ffce6ea07b3c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 10:40:42 2022 -0700
[BitSet] Adjust test for updated mirror display style
commit d2099dd6cb093520f1529100e42293df58f5d9c6
Merge: 145e949 207029a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 28 10:37:15 2022 -0700
Merge pull request #226 from lorentey/improve-OrderedSet-initializer
[OrderedSet] Improve sequence-taking initializer
commit 145e9499f300af1d6240f179569641f8b4db1954
Merge: 0000ddb 68bc656
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:37:43 2022 -0700
Merge pull request #227 from lorentey/Xcode-gardening
[Xcode] Disable implicit dependencies
commit 68bc6567be4c1ae96cfea1217b9e5cee63421c6a
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sat Oct 22 11:39:52 2022 -0700
[Xcode] Disable implicit dependencies
commit 207029a613dca008e708370c09fc69010cf6a11d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sat Oct 22 17:28:06 2022 -0700
[OrderedSet] Improve Sequence initializer
commit 2dae70dba7fc4c5b01e8e7251f827233cf5413fc
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 26 18:09:09 2022 -0700
[OrderedSet, BitSet] Fix display style of custom mirror
commit 18a01247a3c5162954a5e5c2794b67251d5e8f66
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 18:00:34 2022 -0700
[PersistentDictionary] Add missing documentation comments
commit 57554c65c259f1c14db0083c4b7f96bd1f7bc3b2
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 10:57:16 2022 -0700
[PersistentDictionary] Add an argument label for init(keys:valueGenerator:)
commit 6dd3756609011243f88007cb250c4899e85c725d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 10:56:36 2022 -0700
[PersistentDictionary] Remove init(uniqueKeys:values:)
This initializer was interesting for OrderedDictionary, where it made
for more efficient initialization of storage, but it’s less useful for
other dictionary types.
commit 8a1b16229ba39afa7eed7aac6639115f804547ba
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 10:55:24 2022 -0700
[PersistentDictionary] Add initializer taking Self
commit 1e1decfa6efdd848690d0a6b044c41d19af243a1
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 17:59:54 2022 -0700
[PersistentCollections] Tweak DocC docs
commit d8e8f5cc1950bd5c38b57253435ffbe099d6df54
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 17:59:31 2022 -0700
[PersistentDictionary] Tweak docs
commit 7dd47aa336078eb04e879749bfc93c6aa6f4a420
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 26 18:09:50 2022 -0700
[Benchmark] Work on PeristentSet and PersistentDictionary benchmarks
commit 16687d78afa9754b7b9062e4c3077e7fca989efd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 26 18:08:25 2022 -0700
[PersistentSet] Add more tests
commit 1d2a52779cf45b6301b73ddc8c3aa44612eff2f3
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 26 15:52:12 2022 -0700
[PersistentSet] Add missing docs
commit 84356e58c75abbcc4de4de1c641ec568bbc890fd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 26 15:50:53 2022 -0700
[PersistentCollection] Back out BidirectionalCollection conformance
BidirectionalCollection has the connotation that the ordering
of elements is meaningful, which isn’t the case for PersistentSet
and PersistentDictionary.
commit 82b7a5396086809b68347be98b58498c083ef3ca
Author: Karoy Lorentey <klorentey@apple.com>
Date: Mon Oct 24 17:38:55 2022 -0700
[PersistentCollections] Categorize member APIs
commit 3d807118ba1c1b7529fb75d2ea327e539aa21720
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 27 17:50:49 2022 -0700
[PersistentCollections] Start working on DocC support
commit 0000ddb00bac9ef273b1926c757da19d20753104
Merge: 4bb2b39 72e2df5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 21 20:01:50 2022 -0700
Merge pull request #223 from lorentey/review-set-operations
Review and finalize (?) binary set operations for 1.1
commit 72e2df59e3ea600f4d5e67a324bd6df1a7acbd41
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 21 18:23:53 2022 -0700
Update gitignore
commit 4fcb37f6ac04a18cf73f0240ebf5c6f050664c83
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 21 19:48:56 2022 -0700
[_CollectionsUtilities] Adjust DictionaryAPIChecker
commit e3cc498060e8891c8754605ecb3ccfad14e1235d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 21 19:48:36 2022 -0700
[BitSet.Counted] Review, test, fix, and document binary set operations & predicates
commit 1355d478afc506d2bb9ccb42116534c421d006f9
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 21 18:23:31 2022 -0700
[BitSet] Review, test, extend, and document binary set operations
commit 0914e6f546b303450a3d16f883267d4b89ee932c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Fri Oct 21 16:32:17 2022 -0700
[OrderedSet] More test coverage for set operations; clarify docs
commit 3a07b859e060e5afa02f57ee7b92b2b0891b870b
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 18:26:26 2022 -0700
[OrderedSet] Split SetAlgebra binary operations into individual files
commit 648aaa7f569308db113280d093798aacaa11e7c7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 18:18:48 2022 -0700
[PersistentSet] Review, test, fix, and document binary set operations
commit 4bb2b391753ba3e5b47231ed2826fc90962d0eef
Merge: 73f6dda 2df7f6d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 18:02:29 2022 -0700
Merge pull request #222 from lorentey/review-descriptions
Review & update descriptions throughout the package
commit 2df7f6d3a8fe5f9bb12b5034da2e095424694d44
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 17:15:21 2022 -0700
Update xcode schemes
commit ab750075a2283a5d5199248149f0b89b71b26683
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 13:32:04 2022 -0700
[PersistentCollections] Add missing Custom[Debug]StringConvertable conformances, review existing ones
Add `Custom[Debug]StringConformance` conformances on:
- `PersistentDictionary.Keys`
- `PersistentDictionary.Values`
- `PersistentDictionary.Index`
- `PersistentSet.Index`
commit 9cd030f21e7c7f1895d8d64f6a7413ddcda390d1
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 13:30:07 2022 -0700
[BitSet] Add missing Custom[Debug]StringConvertable conformances, review existing ones
Add `Custom[Debug]StringConvertible` conformance on `BitSet.Index`.
commit c12b454da138416aa3c7aa97ca46c36d4a1ca918
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 13:29:33 2022 -0700
[Heap] Add missing Custom[Debug]StringConvertable conformances, review existing ones
Add `Custom[Debug]StringConvertible` conformance on `Heap`.
commit 71434218009c539b34acef6fe23d6b4c8f91b205
Author: Karoy Lorentey <klorentey@apple.com>
Date: Thu Oct 20 13:29:10 2022 -0700
[OrderedCollections] Add missing Custom[Debug]StringConvertable conformances, review existing ones
Add `Custom[Debug]StringConvertible` conformance on:
- `OrderedDictionary.Values`
- `OrderedDictionary.Elements.Subsequence`
- `OrderedSet.SubSequence`
commit 73f6ddacc022c96f9a3260b8d3eaea69fa289a97
Merge: 51ad2c4 5783b82
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 19:47:28 2022 -0700
Merge pull request #221 from lorentey/fix-unusual-build-problems
Fix unusual build problems
commit 4196e652b101ccbbdb5431433b3a7ea0b414f708
Merge: de1776b d3987c7
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 19:35:22 2022 -0700
Merge pull request #220 from lorentey/merge.1.1→main
Merge latest changes from release/1.1 to main
commit 5783b82d72e620f37545924d46bdbfb429f03cbb
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 19:33:33 2022 -0700
[PersistentCollections] Fix building with library stability enabled
Building this package with library stability enabled
is entirely unsupported, but let’s add a few @frozen
attributes to fix such builds anyway.
This package is explicitly not ABI stable; the @frozen
attribute does not mean a guarantee to leave
layout unchanged in future revisions.
commit e74283a2fa64c490197edbf3192760a166020e5d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 18:43:12 2022 -0700
[PersistentCollections] Remove BitmapSmokeTests.swift
The underlying code no longer looks like what we had before,
and @testable imports need to be disabled in release builds.
We should be testing internals, but this isn’t carrying much
weight right now.
Also remove a couple of PersistentDictionary smoke tests that
are also relying on @testable.
commit d3987c79a1214e279a49a09304c13322560c8a1b
Merge: de1776b 51ad2c4
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 18:25:48 2022 -0700
Merge branch 'release/1.1'
# Conflicts:
# Package.swift
# Sources/PersistentCollections/PersistentSet/PersistentSet+Extras.swift
# Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra isEqual.swift
# Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra isStrictSubset.swift
commit 51ad2c403e3e90c88e7ec145467a10cca8ed1728
Merge: 60bc1ef 67fdff5
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 18:11:02 2022 -0700
Merge pull request #219 from lorentey/cherry-pick-changes-main→1.1
Cherry pick changes from main to release/1.1
commit 67fdff5a25539a51ce2a8bf574a7e4a6b72ebfb8
Author: Saleem Abdulrasool <compnerd@compnerd.org>
Date: Wed Oct 19 11:14:47 2022 -0700
Update CMakeLists.txt
Remove missing file. Thanks to @stevenbrix for identifying this!
(cherry picked from commit 5e0a0149a4c9b2ab407f65b257b5b36bc589307d)
commit 56be3ae3fdcfc00ec97da7c99dbe481a3dc0be85
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 17:56:22 2022 -0700
[PersistentSet] Adjust code after merge
commit 25fd503fac0a8881ab707dac4348fc871a577acb
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 12 15:08:22 2022 -0700
[PersistentCollections] Fix up code added since c73a8caa originally landed
(cherry picked from commit 4c842df1b8cfc9611762bdf5fbd9023ab2d3d333)
commit bceadab267ce0ef79fcea4a0e322ec4b471ec2c0
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 5 10:26:05 2022 -0700
[PersistentCollections] Reduce popcount usages where possible
# Conflicts:
# Sources/PersistentCollections/Node/_Node+Primitive Removals.swift
(cherry picked from commit e153ebf7985f2c0097bdf1d5302014e6e0e9c962)
commit 6b516b72fb5c6955b02c0eb8de0b9a8e3c579d08
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sat Oct 1 12:37:05 2022 -0700
[PersistentCollections] Slightly more readable index descriptions
(cherry picked from commit 785caa4a55f2638b11b4a89124f0220a26337ca4)
commit 2e276ba42b7c723dd142fc8149cccaf3bf49acdd
Author: Karoy Lorentey <klorentey@apple.com>
Date: Sat Oct 1 12:36:42 2022 -0700
[PersistentCollections] Clean up _Node.Builder & removals
This sanitizes the semantics of _Node.Builder, removing
the (unneccessary) need to pass around hash paths.
It also slightly refactors removal operations, but stops short of
implementing node shrinking.
# Conflicts:
# Sources/PersistentCollections/Node/_Node+Builder.swift
# Sources/PersistentCollections/Node/_Node+Initializers.swift
# Sources/PersistentCollections/Node/_Node+Structural intersection.swift
# Sources/PersistentCollections/Node/_Node+Structural subtracting.swift
# Sources/PersistentCollections/Node/_Node+Subtree Modify.swift
# Sources/PersistentCollections/Node/_Node+Subtree Removals.swift
# Sources/PersistentCollections/PersistentDictionary/PersistentDictionary+Initializers.swift
# Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra Initializers.swift
# Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra intersection.swift
# Sources/PersistentCollections/PersistentSet/PersistentSet+SetAlgebra subtracting.swift
(cherry picked from commit c73a8caad13a33043532f8e701e8c932c738808b)
commit 60bc1ef05835c8bf6e84b93046219e9702306996
Merge: 6f986e0 3c6cb8c
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 17:36:38 2022 -0700
Merge pull request #218 from lorentey/update-CMake
Update CMake configuration
commit 3c6cb8cd56d04392bf9f79a2d5020fc2abf1958d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 17:35:13 2022 -0700
Update CMake configuration
commit 6f986e0decd09672c17c85bab6a434f16f531a3f
Merge: a99e0d6 381cf5d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 17:34:06 2022 -0700
Merge pull request #217 from lorentey/merge.1.0→1.1
Merge.1.0→1.1
commit de1776bca0130e8f2956fac57300593c4296296d
Merge: 2385847 5e0a014
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 17:33:54 2022 -0700
Merge pull request #215 from compnerd/patch-2
Update CMakeLists.txt
commit 381cf5d17e46f2d3266bd1be7295118647443313
Merge: a99e0d6 08e91c6
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 15:50:34 2022 -0700
Merge branch 'release/1.0' into release/1.1
commit a99e0d61dfcc9f114cc1470282934ee05a8699af
Merge: b9d8637 734730d
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 15:49:57 2022 -0700
Merge pull request #216 from lorentey/review-set-relation-predicates
Review and finalize (?) set relation predicates for 1.1
commit 734730d72460e7bd536e8021d4aa711cb3aa75b2
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 15:19:46 2022 -0700
[OrderedSet] Split SetAlgebra predicates into individual files
This is to match the layout of all the other
SetAlgebra implementations in this package.
commit 5dfd51238c683fe67162db69db2e774546f4dcec
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 15:10:07 2022 -0700
[OrderedSet] Review, test, fix, and document set relation predicates
commit 8ce8a6bc86a291b5aa8ccb861b298767ba6f0066
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 13:59:43 2022 -0700
[PersistentSet] Review, test, fix, and document set relation predicates
commit f843bd40bff204dd9ee0621eac669198c44a22de
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 01:36:44 2022 -0700
[PersistentSet] Add update(_:at:)
commit 001df8e3253e10b41cdb926286c7ca742db768c4
Author: Karoy Lorentey <klorentey@apple.com>
Date: Wed Oct 19 01:10:09 2022 -0700
[BitSet] Review, test, fix, and document …
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Feb 8, 2024
…v1.1.0 (#906) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com_github_apple_swift_collections](https://togithub.com/apple/swift-collections) | http_archive | minor | `1.0.6` -> `1.1.0` | --- ### Release Notes <details> <summary>apple/swift-collections (com_github_apple_swift_collections)</summary> ### [`v1.1.0`](https://togithub.com/apple/swift-collections/releases/tag/1.1.0): Swift Collections 1.1.0 [Compare Source](https://togithub.com/apple/swift-collections/compare/1.0.6...1.1.0) This feature release adds a number of new data structure implementations, along with minor changes to existing constructs. ##### New Data Structures - `Heap` implements a min-max heap, backed by a native array. (Contributed by [@​AquaGeek](https://togithub.com/AquaGeek)) - `BitSet` and `BitArray` are two alternate representations of a bitmap type, backed by dynamically allocated storage. (Contributed by [@​MahanazAtiqullah](https://togithub.com/MahanazAtiqullah)) - `TreeSet` and `TreeDictionary` are hashed collections implementing Compressed Hash-Array Mapped Prefix Trees (CHAMP). They provide similar API as `Set`/`Dictionary` in the Standard Library, but as persistent data structures, supporting incremental mutations of shared instances and efficient structural diffing. (Contributed by [@​msteindorfer](https://togithub.com/msteindorfer)) ##### Other Changes - This version of the package can only be built using Swift 5.7 or later. - New methods: the `OrderedSet.isEqualSet` family of functions provide a way to test that two containers contain the same members, ignoring the order of elements. ([https://github.com/apple/swift-collections/issues/183](https://togithub.com/apple/swift-collections/issues/183), [https://github.com/apple/swift-collections/pull/234](https://togithub.com/apple/swift-collections/pull/234)) - New method: `OrderedSet.filter` implements a version of the standard filter operation that returns an `OrderedSet` instead of an `Array`. ([https://github.com/apple/swift-collections/pull/159](https://togithub.com/apple/swift-collections/pull/159)) - `debugDescription` implementations have been updated to follow Swift best practice. (These are called by container types like `Array` to print their elements, so they work best when they're succinct variants of `description` that are suitable for embedding in structured output: specifically, they must not produce unpaired delimiter characters (`[`/`]`, `(`/`)`, `{`/`}`, `<`/`>` etc), raw top level commas, semicolons, colons, unquoted strings etc. `debugDescription` should not needlessly print type names etc.) ##### New Contributors - [@​AquaGeek](https://togithub.com/AquaGeek) made their first contribution in [https://github.com/apple/swift-collections/pull/61](https://togithub.com/apple/swift-collections/pull/61) - [@​ejmarchant](https://togithub.com/ejmarchant) made their first contribution in [https://github.com/apple/swift-collections/pull/82](https://togithub.com/apple/swift-collections/pull/82) - [@​just-gull](https://togithub.com/just-gull) made their first contribution in [https://github.com/apple/swift-collections/pull/115](https://togithub.com/apple/swift-collections/pull/115) - [@​jPaolantonio](https://togithub.com/jPaolantonio) made their first contribution in [https://github.com/apple/swift-collections/pull/121](https://togithub.com/apple/swift-collections/pull/121) - [@​MahanazAtiqullah](https://togithub.com/MahanazAtiqullah) made their first contribution in [https://github.com/apple/swift-collections/pull/83](https://togithub.com/apple/swift-collections/pull/83) - [@​hectormatos2011](https://togithub.com/hectormatos2011) made their first contribution in [https://github.com/apple/swift-collections/pull/155](https://togithub.com/apple/swift-collections/pull/155) - [@​ktoso](https://togithub.com/ktoso) made their first contribution in [https://github.com/apple/swift-collections/pull/159](https://togithub.com/apple/swift-collections/pull/159) - [@​CTMacUser](https://togithub.com/CTMacUser) made their first contribution in [https://github.com/apple/swift-collections/pull/116](https://togithub.com/apple/swift-collections/pull/116) - [@​hassila](https://togithub.com/hassila) made their first contribution in [https://github.com/apple/swift-collections/pull/297](https://togithub.com/apple/swift-collections/pull/297) Many thanks to our contributors for their great work (and patience)! ##### List of Pull Requests **Full Changelog**: apple/swift-collections@1.0.6...1.1.0 - Add a min-max heap implementation that can be used to back a priority queue by [@​AquaGeek](https://togithub.com/AquaGeek) in [https://github.com/apple/swift-collections/pull/61](https://togithub.com/apple/swift-collections/pull/61) - \[benchmark] Review and extend Heap benchmarks by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/76](https://togithub.com/apple/swift-collections/pull/76) - Add reference benchmarks for bit vector implementations by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/79](https://togithub.com/apple/swift-collections/pull/79) - Fix Markdown link in README by [@​AquaGeek](https://togithub.com/AquaGeek) in [https://github.com/apple/swift-collections/pull/77](https://togithub.com/apple/swift-collections/pull/77) - Fix documentation for types conforming to ExpressibleByArrayLiteral o… by [@​ejmarchant](https://togithub.com/ejmarchant) in [https://github.com/apple/swift-collections/pull/82](https://togithub.com/apple/swift-collections/pull/82) - \[Heap] Performance tweaks by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/78](https://togithub.com/apple/swift-collections/pull/78) - Fix typos: missing subscript parameters by [@​ejmarchant](https://togithub.com/ejmarchant) in [https://github.com/apple/swift-collections/pull/81](https://togithub.com/apple/swift-collections/pull/81) - \[Heap] Update implementation details section in docs by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/84](https://togithub.com/apple/swift-collections/pull/84) - Update CMakeLists.txt by [@​compnerd](https://togithub.com/compnerd) in [https://github.com/apple/swift-collections/pull/85](https://togithub.com/apple/swift-collections/pull/85) - Stop depending on swift-collections-benchmark by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/86](https://togithub.com/apple/swift-collections/pull/86) - \[OrderedDictionary] modifyValue → updateValue by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/91](https://togithub.com/apple/swift-collections/pull/91) - Add Benchmarks package to workspace by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/93](https://togithub.com/apple/swift-collections/pull/93) - \[OrderedDictionary] Deprecate `subscript(offset:)` for now by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/92](https://togithub.com/apple/swift-collections/pull/92) - Documentation: Remove in-place mutation comments by [@​ejmarchant](https://togithub.com/ejmarchant) in [https://github.com/apple/swift-collections/pull/96](https://togithub.com/apple/swift-collections/pull/96) - \[main] Freeze some types for consistency with their inlinable initializers by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/98](https://togithub.com/apple/swift-collections/pull/98) - Follow stdlib's leading underscore rule by [@​ejmarchant](https://togithub.com/ejmarchant) in [https://github.com/apple/swift-collections/pull/95](https://togithub.com/apple/swift-collections/pull/95) - \[Heap] Disable heap tests in release builds by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/100](https://togithub.com/apple/swift-collections/pull/100) - \[NFC] Merge release/1.0 to main by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/105](https://togithub.com/apple/swift-collections/pull/105) - Merge `release/1.0` into `main` by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/108](https://togithub.com/apple/swift-collections/pull/108) - \[README] Note that `Heap` hasn't been tagged yet & list other enhancements in progress by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/109](https://togithub.com/apple/swift-collections/pull/109) - PriorityQueueModule: remove `import Foundation` by [@​compnerd](https://togithub.com/compnerd) in [https://github.com/apple/swift-collections/pull/118](https://togithub.com/apple/swift-collections/pull/118) - \[Heap] Remove Heap's `ascending` and `descending` views by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/119](https://togithub.com/apple/swift-collections/pull/119) - \[Heap] Enable heap tests in optimized builds ([#​101](https://togithub.com/apple/swift-collections/issues/101)) by [@​just-gull](https://togithub.com/just-gull) in [https://github.com/apple/swift-collections/pull/115](https://togithub.com/apple/swift-collections/pull/115) - Update CMakeLists.txt by [@​compnerd](https://togithub.com/compnerd) in [https://github.com/apple/swift-collections/pull/122](https://togithub.com/apple/swift-collections/pull/122) - Fix link to package internal documentation by [@​jPaolantonio](https://togithub.com/jPaolantonio) in [https://github.com/apple/swift-collections/pull/121](https://togithub.com/apple/swift-collections/pull/121) - Merge release/1.0 to main by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/130](https://togithub.com/apple/swift-collections/pull/130) - BitArray and BitSet data structures by [@​MahanazAtiqullah](https://togithub.com/MahanazAtiqullah) in [https://github.com/apple/swift-collections/pull/83](https://togithub.com/apple/swift-collections/pull/83) - Sorted collections by [@​vihanb](https://togithub.com/vihanb) in [https://github.com/apple/swift-collections/pull/65](https://togithub.com/apple/swift-collections/pull/65) - Merge `release/1.0` to `main` by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/141](https://togithub.com/apple/swift-collections/pull/141) - Remove Swift PM Artifacts to avoid Generated Schemes in Xcode by [@​hectormatos2011](https://togithub.com/hectormatos2011) in [https://github.com/apple/swift-collections/pull/155](https://togithub.com/apple/swift-collections/pull/155) - Reinstate custom schemes under Utils/swift-collections.xcworkspace by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/156](https://togithub.com/apple/swift-collections/pull/156) - \+OrderedSet add filter [#​158](https://togithub.com/apple/swift-collections/issues/158) by [@​ktoso](https://togithub.com/ktoso) in [https://github.com/apple/swift-collections/pull/159](https://togithub.com/apple/swift-collections/pull/159) - \[Xcode] Update schemes & file template by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/161](https://togithub.com/apple/swift-collections/pull/161) - \[OrderedCollection] Use standard temp allocation facility, if available by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/160](https://togithub.com/apple/swift-collections/pull/160) - \[OrderedSet] Work around weird name lookup issue in compiler by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/162](https://togithub.com/apple/swift-collections/pull/162) - \=OrderedSet.filter Attempt to optimize filter impl by [@​ktoso](https://togithub.com/ktoso) in [https://github.com/apple/swift-collections/pull/163](https://togithub.com/apple/swift-collections/pull/163) - Force-inline \_modify accessors to work around a performance issue by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/165](https://togithub.com/apple/swift-collections/pull/165) - Merge release/1.0 branch to main by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/172](https://togithub.com/apple/swift-collections/pull/172) - Incubate persistent data structures by [@​msteindorfer](https://togithub.com/msteindorfer) in [https://github.com/apple/swift-collections/pull/31](https://togithub.com/apple/swift-collections/pull/31) - Persistent collections updates by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/174](https://togithub.com/apple/swift-collections/pull/174) - Persistent collections updates by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/175](https://togithub.com/apple/swift-collections/pull/175) - Persistent collections updates (part 3) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/176](https://togithub.com/apple/swift-collections/pull/176) - Persistent collections updates (part 4) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/177](https://togithub.com/apple/swift-collections/pull/177) - \[OrderedDictionary] Tiny documentation fix by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/178](https://togithub.com/apple/swift-collections/pull/178) - Persistent collections updates (part 5) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/179](https://togithub.com/apple/swift-collections/pull/179) - Integrate PriorityQueueModule, BitCollections, PersistentCollections, SortedCollections into release/1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/181](https://togithub.com/apple/swift-collections/pull/181) - Persistent collections updates (part 6) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/180](https://togithub.com/apple/swift-collections/pull/180) - Persistent collections updates (part 7) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/182](https://togithub.com/apple/swift-collections/pull/182) - \[BitSet] Fix decoding format on 32 bit architectures by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/185](https://togithub.com/apple/swift-collections/pull/185) - Persistent collections updates (part 8) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/184](https://togithub.com/apple/swift-collections/pull/184) - Persistent collections updates (part 9) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/188](https://togithub.com/apple/swift-collections/pull/188) - Add Sendable conformances to all public types by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/191](https://togithub.com/apple/swift-collections/pull/191) - \[test] Check baseline API expectations for set-like types by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/192](https://togithub.com/apple/swift-collections/pull/192) - Fleshing out `PersistentSet` by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/193](https://togithub.com/apple/swift-collections/pull/193) - Rename `PriorityQueueModule` to `HeapModule` by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/194](https://togithub.com/apple/swift-collections/pull/194) - \[BitSet] Fix invariant violation in member subscript by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/195](https://togithub.com/apple/swift-collections/pull/195) - \[1.1.0] Bump minimum required Swift toolchain to 5.5 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/196](https://togithub.com/apple/swift-collections/pull/196) - Restore support for building with Swift 5.5 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/198](https://togithub.com/apple/swift-collections/pull/198) - Merge release/1.0 to release/1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/199](https://togithub.com/apple/swift-collections/pull/199) - Update CMake configuration in preparation for 1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/200](https://togithub.com/apple/swift-collections/pull/200) - Update CMakeLists.txt by [@​compnerd](https://togithub.com/compnerd) in [https://github.com/apple/swift-collections/pull/202](https://togithub.com/apple/swift-collections/pull/202) - \[1.1]\[SortedCollections] Remove for now by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/205](https://togithub.com/apple/swift-collections/pull/205) - \[Heap] Change value of minimum or maximum element by [@​CTMacUser](https://togithub.com/CTMacUser) in [https://github.com/apple/swift-collections/pull/116](https://togithub.com/apple/swift-collections/pull/116) - \[Heap] Prerelease preparations by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/210](https://togithub.com/apple/swift-collections/pull/210) - Update README files by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/212](https://togithub.com/apple/swift-collections/pull/212) - \[manifest] Exclude CMakeLists.txt; remove unnecessary path settings; reindent file by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/213](https://togithub.com/apple/swift-collections/pull/213) - Review and finalize (?) set relation predicates for 1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/216](https://togithub.com/apple/swift-collections/pull/216) - Merge.1.0→1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/217](https://togithub.com/apple/swift-collections/pull/217) - Update CMake configuration by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/218](https://togithub.com/apple/swift-collections/pull/218) - Cherry pick changes from main to release/1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/219](https://togithub.com/apple/swift-collections/pull/219) - Fix unusual build problems by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/221](https://togithub.com/apple/swift-collections/pull/221) - Review & update descriptions throughout the package by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/222](https://togithub.com/apple/swift-collections/pull/222) - Review and finalize (?) binary set operations for 1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/223](https://togithub.com/apple/swift-collections/pull/223) - \[Xcode] Disable implicit dependencies by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/227](https://togithub.com/apple/swift-collections/pull/227) - \[OrderedSet] Improve sequence-taking initializer by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/226](https://togithub.com/apple/swift-collections/pull/226) - \[OrderedSet, BitSet] Fix custom mirror display style by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/225](https://togithub.com/apple/swift-collections/pull/225) - Finalize persistent collections API by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/224](https://togithub.com/apple/swift-collections/pull/224) - Start working on DocC support by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/228](https://togithub.com/apple/swift-collections/pull/228) - Update CMake build configuration by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/230](https://togithub.com/apple/swift-collections/pull/230) - \[PersistentSet] Iterator.next(): Make inlinable by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/233](https://togithub.com/apple/swift-collections/pull/233) - \[SetAlgebra types] isEqual(to:) → isEqualSet(to:) by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/234](https://togithub.com/apple/swift-collections/pull/234) - \[PersistentCollections] Doc & benchmark updates in preparation of API review by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/235](https://togithub.com/apple/swift-collections/pull/235) - Apply changes from in-progress review thread by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/237](https://togithub.com/apple/swift-collections/pull/237) - \[ShareableHashedCollections] API Review: add missing `mutating` keywords by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/238](https://togithub.com/apple/swift-collections/pull/238) - \[Benchmarks] Split default huge library up into individual files, one per type by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/240](https://togithub.com/apple/swift-collections/pull/240) - \[ShareableHashedCollections] Add missing import by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/243](https://togithub.com/apple/swift-collections/pull/243) - Unify unsafe bit set implementations by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/244](https://togithub.com/apple/swift-collections/pull/244) - Fix warnings in development versions of Swift by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/245](https://togithub.com/apple/swift-collections/pull/245) - \[HashTreeCollections] Change prefix `Shareable` to `Tree` by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/242](https://togithub.com/apple/swift-collections/pull/242) - \[TreeDictionary] Fix in-place merge operation to properly update the count by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/247](https://togithub.com/apple/swift-collections/pull/247) - \[cmake] Update CMake configuration by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/249](https://togithub.com/apple/swift-collections/pull/249) - Add not so experimental rope implementation by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/264](https://togithub.com/apple/swift-collections/pull/264) - Fix off by one error in BitSet by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/267](https://togithub.com/apple/swift-collections/pull/267) - Monomodule support by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/266](https://togithub.com/apple/swift-collections/pull/266) - Expose a handful of BigString.Index methods by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/269](https://togithub.com/apple/swift-collections/pull/269) - BitArray API refinements & additions by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/263](https://togithub.com/apple/swift-collections/pull/263) - Make most of Rope inlinable by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/270](https://togithub.com/apple/swift-collections/pull/270) - BigString: Fix String.Index.\_knownScalarAligned by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/272](https://togithub.com/apple/swift-collections/pull/272) - Rope: Fix `Sendable` conformance by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/271](https://togithub.com/apple/swift-collections/pull/271) - Require Swift 5.6 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/273](https://togithub.com/apple/swift-collections/pull/273) - \[OrderedDictionary] Explicitly mention in documentation that keys/values are ordered by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/275](https://togithub.com/apple/swift-collections/pull/275) - \[HashCollections] Ensure `self` doesn’t get destroyed before we’re done working with it by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/276](https://togithub.com/apple/swift-collections/pull/276) - Remove obsolete swift(>=5.5)/swift(>=5.6) checks by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/277](https://togithub.com/apple/swift-collections/pull/277) - \[Xcode] Update Xcode project by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/278](https://togithub.com/apple/swift-collections/pull/278) - Minor rope updates by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/279](https://togithub.com/apple/swift-collections/pull/279) - \[Rope] remove(at:): Fix assertion when removing the last item creates a deficiency by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/280](https://togithub.com/apple/swift-collections/pull/280) - Merge changes from release 1.0 to release 1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/283](https://togithub.com/apple/swift-collections/pull/283) - \[CollectionUtilities] Silence a warning on 32 bit platforms by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/286](https://togithub.com/apple/swift-collections/pull/286) - \[BitSet] Fix a thinko in BitSet.isEqualSet by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/287](https://togithub.com/apple/swift-collections/pull/287) - Grab bag of fixes for small test issues by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/288](https://togithub.com/apple/swift-collections/pull/288) - \[Xcode] Set a code sign identity in the Xcode project by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/285](https://togithub.com/apple/swift-collections/pull/285) - Rope: Fix trap when replaceSubrange is called on an empty rope by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/290](https://togithub.com/apple/swift-collections/pull/290) - `Rope.find` returns a bogus remainder for the end position by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/291](https://togithub.com/apple/swift-collections/pull/291) - Update TreeSet.md by [@​hassila](https://togithub.com/hassila) in [https://github.com/apple/swift-collections/pull/297](https://togithub.com/apple/swift-collections/pull/297) - Fix CustomStringConvertible/CustomDebugStringConvertible conformances by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/302](https://togithub.com/apple/swift-collections/pull/302) - \[RopeModule] Fix issues in Swift's ABI stable dialect by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/318](https://togithub.com/apple/swift-collections/pull/318) - \[CMake, Xcode] Update configurations for alternate build systems by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/319](https://togithub.com/apple/swift-collections/pull/319) - \[RopeModule] Remove unnecessary typealiases by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/320](https://togithub.com/apple/swift-collections/pull/320) - \[Heap] Improve type-level doc comment by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/326](https://togithub.com/apple/swift-collections/pull/326) - \[Heap] insert(contentsOf:) Switch to Floyd’s if we’re inserting too many items by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/327](https://togithub.com/apple/swift-collections/pull/327) - \[1.1] build: support building in Debug mode on Windows by [@​compnerd](https://togithub.com/compnerd) in [https://github.com/apple/swift-collections/pull/336](https://togithub.com/apple/swift-collections/pull/336) - Merge release/1.0 to release/1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/348](https://togithub.com/apple/swift-collections/pull/348) - \[Heap] Convert min() and max() to properties by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/328](https://togithub.com/apple/swift-collections/pull/328) - \[BitArray] Disable bitwise operators for now by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/353](https://togithub.com/apple/swift-collections/pull/353) - \[Heap] Final(?) Heap API adjustments for 1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/354](https://togithub.com/apple/swift-collections/pull/354) - \[Benchmarks] Add Collection Equality Benchmarks by [@​vanvoorden](https://togithub.com/vanvoorden) in [https://github.com/apple/swift-collections/pull/351](https://togithub.com/apple/swift-collections/pull/351) - Release preparations for 1.1 by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/355](https://togithub.com/apple/swift-collections/pull/355) - \[1.1] Fix typos by [@​lorentey](https://togithub.com/lorentey) in [https://github.com/apple/swift-collections/pull/357](https://togithub.com/apple/swift-collections/pull/357) - \[TreeDictionary]\[Keys] Add Equatable and Hashable Conformance to TreeDictionary.Keys by [@​vanvoorden](https://togithub.com/vanvoorden) in [https://github.com/apple/swift-collections/pull/352](https://togithub.com/apple/swift-collections/pull/352) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
BitSet._UnsafeHandleinto_CollectionsUtilities, and start using it inOrderedCollections, instead of a custom type.BitCollections.BitSet._UnsafeHandle→_CollectionsUtilities._UnsafeBitSetBitCollections._Word→_CollectionsUtilities._UnsafeBitSet._WordBitCollections._BitPosition→CollectionsUtilities._UnsafeBitSet.IndexChecklist