Fixed navigationViewStyle and wrapped controller presentationStyle for iPad #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows the content as a single top view on iPad instead of a split view and simplifies navigation.
Closed
|
As mentioned in #1, the later commits here fix the iPad presentation issue by using an explicit |
pseligman
approved these changes
Jun 14, 2021
sjrmanning
changed the title
sjrmanning
added a commit
that referenced
this pull request
Feb 1, 2022
* added link to branch * added link to branch * Update README.md * Fixed navigationViewStyle and wrapped controller presentationStyle for iPad (#2) * Use explicit navigationViewStyle on ContentView NavigationView. This shows the content as a single top view on iPad instead of a split view and simplifies navigation. * Use explicit modalPresentationStyle to fix iPad presentation issue. * Updated comment brought over from another sample. * Support for re-using existing shares on swift-concurrency branch. * Reuse existing CKShare if it already exists (#6) * Reuse existing CKShare if it already exists If a contact is already shared we use the existing CKShare object. fixes #5 * Rename func createShare * Rename ViewModelError `unknown` case Co-authored-by: Tony Tam <tonytam@apple.com> Co-authored-by: Tony Tam <tony@eatbacon.org> Co-authored-by: César Pinto Castillo <jagcesar@me.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default iPad is using a split view so the contact list is only showing on the left in a split view. This sets an explicit
navigationViewStyleto show the content as a single top view on iPad instead of a split view.Related to #1