Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes modals deep selectors #4795

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fixes modals deep selectors #4795

merged 1 commit into from
Nov 11, 2024

Conversation

ValJed
Copy link
Contributor

@ValJed ValJed commented Nov 7, 2024

PRO-6783

Summary

Fix modal style when using vite to build

What are the specific steps to test this change?

Check Unsaved Changes modal
as well as share draft
and others (the ones that override AposModal style)

What kind of change does this PR introduce?

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Build-related changes
  • Other

Make sure the PR fulfills these requirements:

  • It includes a) the existing issue ID being resolved, b) a convincing reason for adding this feature, or c) a clear description of the bug it resolves
  • The changelog is updated
  • Related documentation has been updated
  • Related tests have been updated

Copy link

linear bot commented Nov 7, 2024

@ValJed ValJed requested review from ETLaurent and haroun November 7, 2024 15:56
@ValJed ValJed merged commit 8495063 into main Nov 11, 2024
9 checks passed
@ValJed ValJed deleted the pro-6783-broken-modals-vite branch November 11, 2024 15:49
haroun added a commit that referenced this pull request Nov 12, 2024
haroun added a commit that referenced this pull request Nov 12, 2024
* main:
  changelog (#4802)
  fixes modals deep selectors (#4795)
  fix vue warnings (#4797)
  Pro 6694 breakpoint preview vite ready (#4789)
  Resolve yaml dependency conflicts (#4801)
  PRO-6775: External frontend support, docs cleanup (#4799)
  sort glob result (#4796)
  HMR condition argument and widget player fix (#4794)
  fix permission grid tooltip display (#4792)
  Fix extra bundle detection (#4791)
  release 4.9.0 (#4788)
  Pro 6535 revision (#4787)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants