[Relax] Validate StructInfo annotations in well-formed check #17331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
relax_well_formed_validate_sinfo_of_expr
branch
from
23e6cf2 to
c3fdc0a
Compare
Lunderberg
force-pushed
the
relax_well_formed_validate_sinfo_of_expr
branch
from
b8fa328 to
a0b8e94
Compare
Prior to this commit, the Relax well-formed checker verified that each expression had a non-null `StructInfo` annotation, but did not perform any validation on the contents of the `StructInfo` annotation. This commit updates the Relax well-formed check to verify that the `StructInfo` annotations are accurate by comparing against the `StructInfo` that would be inferred for an expression. (This only requires that the information is accurate, not that it is complete. For example, an expression that is inferred to be `R.Tensor(shape=[128,8], dtype="float32")` may have annotation of `R.Tensor(ndim=2, dtype="float32"`, but may not have an annotation of `R.Tensor(shape=[128,8], dtype="int32")`.)
Lunderberg
force-pushed
the
relax_well_formed_validate_sinfo_of_expr
branch
from
84e2036 to
842b092
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the Relax well-formed checker verified that each expression had a non-null
StructInfoannotation, but did not perform any validation on the contents of theStructInfoannotation.This commit updates the Relax well-formed check to verify that the
StructInfoannotations are accurate by comparing against theStructInfothat would be inferred for an expression. (This only requires that the information is accurate, not that it is complete. For example, an expression that is inferred to beR.Tensor(shape=[128,8], dtype="float32")may have annotation ofR.Tensor(ndim=2, dtype="float32", but may not have an annotation ofR.Tensor(shape=[128,8], dtype="int32").)