[Relax][Bugfix] Support torch.unbind op and fix bugs for expand && split #17292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archermmt
changed the title
Archermmt
changed the title
mshr-h
reviewed
Aug 22, 2024
mshr-h
reviewed
Aug 22, 2024
mshr-h
reviewed
Aug 22, 2024
mshr-h
reviewed
Aug 22, 2024
|
@tvm-bot rerun |
|
@mshr-h Could you please help to review? thanks in advance! |
mshr-h
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
@Archermmt LGTM, thank you for the update. Since I am not an official reviewer/committer, let's ask the committers to check the PR.
@yongwww @vinx13 @MasterJH5574 Can you please take a look at it? Thanks!
tqchen
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.support unbind op and add unit tests. unbind op:https://pytorch.org/docs/stable/generated/torch.unbind.html
example:
torch.unbind(torch.tensor([[1, 2, 3], [4, 5, 6],[7, 8, 9]]))
-> (tensor([1, 2, 3]), tensor([4, 5, 6]), tensor([7, 8, 9]))
2.bug fix for expand op, when -1 is given as expand dim(keep the same dim):
https://pytorch.org/docs/stable/generated/torch.Tensor.expand.html
3.support split op with split sections
cc @mshr-h
Could you please help to review? thanks in advance