[IR] Handle NaN in StructuralEqual and StructuralHash #17249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
NaN
values did not have any special handling in eitherStructuralEqual
orStructuralHash
.StructuralEqual
checked whether the LHS and RHS were within some tolerance of each other. If the LHS and RHS are bothNaN
, this would evaluate to false. The updatedStructuralEqual
now checks for this case, and returns true if both sides areNaN
.StructuralHash
used the bit-pattern of a floating-point number to compute the hash. ANaN
value may have any non-zero value in its mantissa, and so this could produce distinct hashes for ASTs that differ only by the choice of non-zero value. The updatedStructuralHash
uses the samestd::numeric_limits<double::quiet_NaN()
value for allNaN
values.With these changes,
StructuralEqual
andStructuralHash
can now compare two IR functions, even if they containNaN
.Closes #17247