Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][Relax] Preserve existing DataflowBlock in ConvertToDataflow #17148

Merged

Conversation

Lunderberg
Copy link
Contributor

The relax.transform.ConvertToDataflow identifies portions of a Relax function that satisfy the requirements of a relax::DataflowBlock, and converts those portions to a new DataflowBlock, provided they are at least some minimum number of operations. Prior to this commit, if a function contained a region that would be converted to a DataflowBlock, but also contains existing DataflowBlocks that were smaller than the size required for creating a DataflowBlock, those existing blocks would be erroneously converted to non-dataflow.

This commit updates the ConvertToDataflow pass to preserve all existing DataflowBlock present in the input.

The `relax.transform.ConvertToDataflow` identifies portions of a Relax
function that satisfy the requirements of a `relax::DataflowBlock`,
and converts those portions to a new `DataflowBlock`, provided they
are at least some minimum number of operations.  Prior to this
commit, if a function contained a region that would be converted to a
`DataflowBlock`, but also contains existing `DataflowBlock`s that were
smaller than the size required for creating a `DataflowBlock`, those
existing blocks would be erroneously converted to non-dataflow.

This commit updates the `ConvertToDataflow` pass to preserve all
existing `DataflowBlock` present in the input.
@tqchen tqchen merged commit eb011c7 into apache:main Sep 13, 2024
19 checks passed
@Lunderberg Lunderberg deleted the bugfix_convert_to_dataflow_preserve_existing branch September 13, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants