Splitting up some of the Docker build steps #8775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## master #8775 +/- ##
==========================================
- Coverage 72.07% 65.83% -6.24%
==========================================
Files 123 482 +359
Lines 12844 24155 +11311
Branches 0 2770 +2770
==========================================
+ Hits 9257 15903 +6646
- Misses 3587 8074 +4487
- Partials 0 178 +178
Continue to review full report at Codecov.
|
mistercrunch
reviewed
Dec 5, 2019
Dockerfile
Outdated
| COPY superset /app/superset | ||
|
|
||
| # First, we just wanna install requirements, which will allow us to utilize the cache | ||
| # in order to only build iff requirements change |
There was a problem hiding this comment.
Fixed iff -> if and only if
mistercrunch
reviewed
Dec 5, 2019
… configs to handle async query running
mistercrunch
approved these changes
Dec 6, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Some folks were seeing errors when building the updated Dockerfile due to the fact that we were bundling several NPM commands in a single RUN
Fixes #8762 ??
REVIEWERS
@dpgaspar