chore: deprecate restricted metrics #8197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
john-bodley
approved these changes
Sep 9, 2019
john-bodley
reviewed
Sep 9, 2019
|
|
||
|
|
||
| def upgrade(): | ||
| op.drop_column("metrics", "is_restricted") |
There was a problem hiding this comment.
I think you need to use op.batch_alter_table to satisfy SQLite.
An early community contribution added the concept of restricted metrics. The idea was to allow for some metrics to be restricted, and if a metric was tagged as such, a user would need to be given access to that metric more explicitely, through a special perm we would maintain for that metric. Now since the new concept of "Adhoc Metrics", the popover that lets a user pick a column and an aggregate function or to write their own SQL expression inline, this restriction is completely bypassed. Adhoc metrics was developed without the restricted metrics in mind. Anyhow, in the near future, we'll be rethinking the ideas behind data-access permissions, and things like column-level or row-level security will be redesigned from scratch. By deprecating this feature, we're removing a confusing and mostly broken feature, and making it easy to move forward
mistercrunch
force-pushed
the
dep_restricted_metrics
branch
from
eae1947 to
ff5be2e
Compare
mistercrunch
commented
Sep 9, 2019
| @@ -10,7 +10,7 @@ | |||
| "scripts": { | |||
| "tdd": "jest --watch", | |||
| "test": "jest", | |||
| "cover": "jest --maxWorkers=8 --coverage", | |||
| "cover": "jest --coverage", | |||
There was a problem hiding this comment.
unrelated to this PR, but this seems to help quite a bit with broken JS builds. For reference, not specifying maxWorkers will lead to use all CPUs cores on the box minus one
Codecov Report
@@ Coverage Diff @@
## master #8197 +/- ##
==========================================
+ Coverage 66.16% 66.17% +<.01%
==========================================
Files 479 479
Lines 22920 22897 -23
Branches 2524 2524
==========================================
- Hits 15164 15151 -13
+ Misses 7622 7612 -10
Partials 134 134
Continue to review full report at Codecov.
|
6 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An early community contribution added the concept of restricted metrics.
The idea was to allow for some metrics to be restricted, and if a metric
was tagged as such, a user would need to be given access to that metric
more explicitely, through a special perm we would maintain for that
metric.
Now since the new concept of "Adhoc Metrics", the popover that lets a
user pick a column and an aggregate function or to write their own SQL
expression inline, this restriction is completely bypassed. Adhoc
metrics was developed without the restricted metrics in mind.
Anyhow, in the near future, we'll be rethinking the ideas behind
data-access permissions, and things like column-level or row-level
security will be redesigned from scratch.
By deprecating this feature, we're removing a confusing and mostly broken
feature, and making it easy to move forward