fix(helm): Fix support for ingress.ingressClassName #18619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craig-rueda
approved these changes
Feb 8, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
In #18617 @joatkh reported removed support for
ingress.ingressClassNameinvalues.yamlof our Chart. It is an undocumented parameter but supported by our Chart:superset/helm/superset/templates/ingress.yaml
Lines 33 to 35 in 1fbdabd
That PR re-add that support.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Use ingress.ingressClassName eg. via
--setduring installation. It should pass validation.ADDITIONAL INFORMATION
@joatkh could you give a shoot to test if it's working for you?
@craig-rueda could you take a look as maintainer of Chart?