Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add make format command #14491

Merged
merged 2 commits into from
May 6, 2021
Merged

feat: add make format command #14491

merged 2 commits into from
May 6, 2021

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 5, 2021

SUMMARY

Created a command to easily format both python and js codebases

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 5, 2021 •
edited
Loading

Codecov Report

Merging #14491 (12dc787) into master (b030c98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14491   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files         953      953           
  Lines       48189    48189           
  Branches     6051     6051           
=======================================
  Hits        37166    37166           
  Misses      10822    10822           
  Partials      201      201
Flag Coverage Δ
hive 80.80% <ø> (ø)
javascript 71.94% <ø> (ø)
mysql 81.06% <ø> (ø)
postgres 81.09% <ø> (ø)
presto 80.79% <ø> (ø)
python 81.63% <ø> (ø)
sqlite 80.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b030c98...12dc787. Read the comment docs.

stevenuray
stevenuray approved these changes May 5, 2021
View reviewed changes
Copy link

@stevenuray stevenuray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hughhhh hughhhh added the need:merge The PR is ready to be merged label May 5, 2021
@hughhhh hughhhh merged commit 96289e9 into master May 6, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
@hughhhh
feat: add make format command (apache#14491)
646cff9 
* Update Makefile

* fix makefile
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@hughhhh
feat: add make format command (apache#14491)
2bd168b 
* Update Makefile

* fix makefile
@rusackas rusackas deleted the hugh/makefile-format branch January 30, 2023 19:21
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@hughhhh
feat: add make format command (apache#14491)
2193ce0 
* Update Makefile

* fix makefile
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

@stevenuray stevenuray stevenuray approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/XS 🚢 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hughhhh @stevenuray @villebro @mistercrunch