Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: set remote URL to https and bump sha #14350

Merged
merged 2 commits into from
Apr 26, 2021
Merged

ci: set remote URL to https and bump sha #14350

merged 2 commits into from
Apr 26, 2021

Conversation

dpgaspar
Copy link
Member

SUMMARY

This change updates the remote submodule from git@github to https. Was causing problems with our CI.

Also bumped the action SHA to the latest

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@nytai
Copy link
Member

nytai commented Apr 26, 2021

Shouldn't we update the url here?

superset/.gitmodules

Line 41 in 7ff35df

url = git@github.com:cpina/github-action-push-to-another-repository.git

@dpgaspar dpgaspar requested a review from nytai April 26, 2021 15:53
@dpgaspar
Copy link
Member Author

Shouldn't we update the url here?

superset/.gitmodules

Line 41 in 7ff35df

url = git@github.com:cpina/github-action-push-to-another-repository.git

probably, I just did the git remote set-url

@dpgaspar dpgaspar merged commit 437be4b into apache:master Apr 26, 2021
@dpgaspar dpgaspar deleted the danielgaspar/fix/action-push-to-another-repo branch April 26, 2021 16:43
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@dpgaspar
ci: set remote URL to https and bump sha (apache#14350)
9e22317 
* ci: set remote URL to https and bump sha

* update gitmodules
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nytai nytai nytai approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpgaspar @nytai @mistercrunch