Codecov Report

Merging #13215 (7ce8d26) into master (2ce7982) will increase coverage by 5.41%.
The diff coverage is 68.49%.

@@            Coverage Diff             @@
##           master   #13215      +/-   ##
==========================================
+ Coverage   53.06%   58.48%   +5.41%     
==========================================
  Files         489      468      -21     
  Lines       17314    15942    -1372     
  Branches     4482     4108     -374     
==========================================
+ Hits         9187     9323     +136     
+ Misses       8127     6619    -1508     

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff8741...7ce8d26. Read the comment docs.

Super excited about this! 🎉 We also probably need to bump it in these places:

• https://github.com/apache/superset/blob/master/Dockerfile#L48
• https://github.com/apache/superset/blob/master/docker-compose.yml#L76

Oops, my bad. Done

Can we stick with current LTS version v14 instead?

Can we stick with current LTS version v14 instead?

I personally prefer keeping these as recent as possible so we can incrementally add support for new features, but If there are concerns that going with v15 will introduce stability issues, I vote going with v14. When reading https://nodejs.org/en/about/releases/ I get the impression that only library developers should go with Current and all others should use LTS. So perhaps v14 is safer.

Yeah, they specifically recommend Production applications should only use Active LTS or Maintenance LTS releases.

We are unlikely to use any cutting-edge features from the current release anyway, so it's probably safer to go with LTS.

I completely agree with Jesse here, generally Node odd numbered releases are full of bugs/issues. I'd feel much better with keeping us at 14

@villebro Done! Thank you for feedback @ktmud @etr2460

@ktmud Done