Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Swap Slack Url 2 more places #13004

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

srinify
Copy link
Contributor

@srinify srinify commented Feb 8, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Feb 8, 2021

Codecov Report

Merging #13004 (e5aea8c) into master (4708ed1) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13004      +/-   ##
==========================================
+ Coverage   52.97%   53.04%   +0.07%     
==========================================
  Files         480      488       +8     
  Lines       17315    17301      -14     
  Branches     4485     4481       -4     
==========================================
+ Hits         9172     9178       +6     
+ Misses       8143     8123      -20     
Flag Coverage Δ
cypress 53.04% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/dashboard/reducers/nativeFilters.ts 100.00% <0.00%> (ø)
...nd/src/dashboard/components/nativeFilters/types.ts 100.00% <0.00%> (ø)
...src/dashboard/components/FiltersBadge/selectors.ts 90.00% <0.00%> (ø)
...src/dashboard/util/activeDashboardNativeFilters.ts 88.88% <0.00%> (ø)
...dashboard/components/nativeFilters/ScopingTree.tsx
...c/dashboard/components/nativeFilters/FilterBar.tsx
...ard/components/nativeFilters/FilterConfigModal.tsx
...mponents/nativeFilters/FilterConfigurationLink.tsx
...oard/components/nativeFilters/FilterConfigForm.tsx
...mponents/nativeFilters/CancelConfirmationAlert.tsx
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4708ed1...e5aea8c. Read the comment docs.

@srinify srinify changed the title Chore: Swap Slack Url 2 more places chore: Swap Slack Url 2 more places Feb 8, 2021
@etr2460 etr2460 merged commit eb5dc38 into apache:master Feb 8, 2021
amitmiran137 pushed a commit to simcha90/incubator-superset that referenced this pull request Feb 10, 2021
* master:
  fix: UI toast typo (apache#13026)
  feat(db engines): add support for Opendistro Elasticsearch (AWS ES) (apache#12602)
  fix(build): black failing on master, add to required checks (apache#13039)
  fix: time filter db migration optimization (apache#13015)
  fix: untranslated text content of Dashboard page (apache#13024)
  fix(ci): remove signature requirements for commits to master (apache#13034)
  fix: add alerts and report to default config (apache#12999)
  docs(changelog): add entries for 1.0.1 (apache#12981)
  ci: skip cypress if no code changes (apache#12982)
  chore: add cypress required checks for branch protection (apache#12970)
  Refresh dashboard list after bulk delete (apache#12945)
  Updates storybook to version 6.1.17 (apache#13014)
  feat: Save datapanel state in local storage (apache#12996)
  fix: added text and changed margins (apache#12923)
  chore: Swap Slack Url 2 more places (apache#13004)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants