Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: eslint curly rule #11913

Merged
merged 2 commits into from
Dec 3, 2020
Merged

style: eslint curly rule #11913

merged 2 commits into from
Dec 3, 2020

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Dec 3, 2020

SUMMARY

On a recent PR, I had a simple if/else, sans-curlies, and @ktmud asked me to put them in. Seemed like a reasonable style call, so I'm adding a lint rule to make sure we're more consistent about this going forward!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Dec 3, 2020 •
edited
Loading

Codecov Report

Merging #11913 (58e3544) into master (61064b9) will increase coverage by 1.55%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11913      +/-   ##
==========================================
+ Coverage   66.04%   67.60%   +1.55%     
==========================================
  Files         927      928       +1     
  Lines       45016    45053      +37     
  Branches     4309     4309              
==========================================
+ Hits        29730    30457     +727     
+ Misses      15151    14493     -658     
+ Partials      135      103      -32
Flag Coverage Δ
cypress 54.89% <0.00%> (+6.04%) ⬆️
javascript 63.18% <71.42%> (+<0.01%) ⬆️
python 64.08% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/utils/downloadAsImage.ts 33.33% <0.00%> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 62.24% <0.00%> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 73.59% <100.00%> (+6.49%) ⬆️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 69.23% <100.00%> (ø)
...et-frontend/src/SqlLab/components/LimitControl.tsx 89.36% <0.00%> (-1.95%) ⬇️
superset/views/base_api.py 97.75% <0.00%> (-0.45%) ⬇️
superset-frontend/src/views/CRUD/types.ts 100.00% <0.00%> (ø)
...t-frontend/src/views/CRUD/data/query/QueryList.tsx 72.11% <0.00%> (ø)
...ns/8ee129739cf9_security_converge_css_templates.py 0.00% <0.00%> (ø)
superset/css_templates/api.py 95.74% <0.00%> (+0.09%) ⬆️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61064b9...58e3544. Read the comment docs.

ktmud
ktmud approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

etr2460
etr2460 reviewed Dec 3, 2020
View reviewed changes
Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add this rule for ts/tsx files too?

As a followup in another PR, we should fix this file so that the TS config extends from the JS one probably

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 3, 2020
@rusackas
Copy link
Member Author

rusackas commented Dec 3, 2020 •
edited
Loading

could you add this rule for ts/tsx files too?

As a followup in another PR, we should fix this file so that the TS config extends from the JS one probably

Hah, I did add the ts one, but forgot to push it! Incoming!

The follow-up PR extending TS from JS makes perfect sense. I'll get to that sometime if nobody beats me to it ;)

@rusackas rusackas merged commit 38b720b into apache:master Dec 3, 2020
@rusackas rusackas deleted the eslint-curly branch December 3, 2020 18:20
@ktmud
Copy link
Member

ktmud commented Dec 3, 2020

Hmm, I thought ESLint overrides extends the root rules?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 left review comments

@villebro villebro villebro approved these changes

@ktmud ktmud ktmud approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rusackas @codecov-io @ktmud @etr2460 @villebro @mistercrunch