fix: Align icon #11848
Merged
fix: Align icon #11848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11848 +/- ##
==========================================
- Coverage 67.12% 63.65% -3.48%
==========================================
Files 915 915
Lines 44537 44529 -8
Branches 4235 4235
==========================================
- Hits 29897 28345 -1552
- Misses 14526 16006 +1480
- Partials 114 178 +64
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rusackas
reviewed
Dec 1, 2020
| @@ -31,6 +31,8 @@ interface FaveStarProps { | |||
|
|
|||
| const StyledLink = styled.a` | |||
| font-size: ${({ theme }) => theme.typography.sizes.xl}px; | |||
| display: flex; | |||
There was a problem hiding this comment.
Hmm... obviously this works, so I'm tempted to approve, but I have to ask out of curiosity:
- Is there a reason to choose 'flex' over 'inline-block'?
- Since you are using flex, would
flex-directon: columnandjustify-content: space-aroundnegate the need to adjust the padding at all?
rusackas
approved these changes
Dec 1, 2020
junlincc
approved these changes
Dec 1, 2020
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix align star icon center
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TEST PLAN
Log into Superset
Navigate to Charts
Select one chart
ADDITIONAL INFORMATION