feat: allow user to view their profile again #11816
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11816 +/- ##
==========================================
+ Coverage 63.59% 67.17% +3.58%
==========================================
Files 916 916
Lines 44479 44547 +68
Branches 4227 4229 +2
==========================================
+ Hits 28286 29925 +1639
+ Misses 16014 14519 -1495
+ Partials 179 103 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| </DropdownMenu.Item> | ||
| )} | ||
| <DropdownMenu.Item key="edit"> | ||
| <a href={navbarRight.user_info_url}>{t('Edit')}</a> |
There was a problem hiding this comment.
For some cases, the default user info url doesn't really allow users to edit their profile. Maybe we should add a permission check here?
There was a problem hiding this comment.
Really? When would a user ever not be able to change their name?
There was a problem hiding this comment.
After looking around, it seems like maybe only admins can edit users.
So I changed the text here to say "Info" instead, which seems to match the url and view name too, so 🤷
etr2460
force-pushed
the
erik-ritter--bring-back-profile-link
branch
from
dbdfe12 to
5c9a6af
Compare
(cherry picked from commit f2d9f00)
mistercrunch
added
🏷️ bot
SUMMARY
At some point, clicking on the Superset logo was redirected to the "Welcome" page (good!). But because of that, it removed any ability for the user to view their own profile (bad...). This PR adds the Profile link in the settings menu and moves the userinfo link to "Info" (a bit more descriptive of what it does i think).
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
CI, ensure the new links work across all pages
ADDITIONAL INFORMATION
to: @betodealmeida @nytai @graceguo-supercat @rusackas