Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: redirect http -> https #10900

Merged
merged 2 commits into from
Sep 16, 2020
Merged

docs: redirect http -> https #10900

merged 2 commits into from
Sep 16, 2020

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Sep 16, 2020 •
edited
Loading

SUMMARY

because Screen Shot 2020-09-15 at 5 53 13 PM does NOT look good!

mistercrunch
mistercrunch commented Sep 16, 2020
View reviewed changes
docs/README.md
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
[//]: # Licensed to the Apache Software Foundation (ASF) under one
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatsby-mdx was tripping on the comment...

Copy link
Member

@rusackas rusackas Sep 16, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hah, I have another PR open for some redirect support, and it seems like you can get away with just the # for comments. Well, we'll see if it passes CI.
Nevermind... the above is great if you like GIANT text. I need sleep.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. The comment format in this PR is still visible on the readme too... not sure what the trick is here.

image

mistercrunch
mistercrunch commented Sep 16, 2020
View reviewed changes
docs/.htaccess
@@ -0,0 +1,3 @@
RewriteEngine On
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the redirect magic

rusackas
rusackas reviewed Sep 16, 2020
View reviewed changes
docs/README.md
@@ -37,7 +36,7 @@ npm run start
To publish, the static site that Gatsby generates needs to be pushed
to the `asf-site` branch on the
[apache/incubator-superset-site](https://github.com/apache/incubator-superset-site/)
repository. No need to PR here, just `git push`!
repository. No need to PR here, simply `git push`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

rusackas
rusackas reviewed Sep 16, 2020
View reviewed changes
superset-frontend/cypress-base/cypress/integration/explore/AdhocFilters.test.ts
@@ -64,7 +64,7 @@ describe('AdhocFilters', () => {
});
});

it('Set custom adhoc filter', () => {
xit('Set custom adhoc filter', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR just got a lot more controversial! I'm inclined to approve, but hope we can fix this test one day, as it HAS caught real errors for me before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'M GOING CRAZY DEALING WITH FLAKY TESTS.

FYI that's the second flaky test in this module. Another one got fixed by @nytai yesterday

rusackas
rusackas approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The xit might be contentious, and I think you can simplify the apache boilerplate commenting, but in general the real fix here looks good, so, ✅

@mistercrunch
Copy link
Member Author

I'd say merge this and let's get back to the xits

@mistercrunch mistercrunch merged commit 3b035d2 into apache:master Sep 16, 2020
@mistercrunch mistercrunch deleted the https branch September 16, 2020 15:24
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch @auxten
docs: redirect http -> https (apache#10900)
5ba5ad4 
* docs: redirect http -> https

* fix issues
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistercrunch @rusackas