Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement contributing.md #10859

Merged
merged 2 commits into from
Sep 14, 2020
Merged

Improvement contributing.md #10859

merged 2 commits into from
Sep 14, 2020

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

  • using Python3 embeded venv libary
  • fix typo

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2020 •
edited
Loading

Codecov Report

Merging #10859 into master will decrease coverage by 4.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10859      +/-   ##
==========================================
- Coverage   65.57%   61.34%   -4.24%     
==========================================
  Files         809      380     -429     
  Lines       38038    24068   -13970     
  Branches     3561        0    -3561     
==========================================
- Hits        24945    14765   -10180     
+ Misses      12987     9303    -3684     
+ Partials      106        0     -106
Flag Coverage Δ
#cypress ?
#javascript ?
#python 61.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 74.46% <0.00%> (ø)
.../src/dashboard/components/FilterTooltipWrapper.jsx
...hboard/components/filterscope/FilterScopeModal.jsx
superset-frontend/src/components/AvatarIcon.tsx
superset-frontend/src/CRUD/CollectionTable.tsx
...d/src/explore/components/MetricDefinitionValue.jsx
...uperset-frontend/src/components/TooltipWrapper.jsx
superset-frontend/src/setup/setupPlugins.ts
...et-frontend/src/dashboard/components/CodeModal.jsx
.../src/explore/components/FilterDefinitionOption.jsx
... and 420 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136f90f...0db3f5b. Read the comment docs.

@willbarrett
Copy link
Member

Thanks for catching!

@willbarrett willbarrett merged commit b4df053 into apache:master Sep 14, 2020
@zhaoyongjie zhaoyongjie deleted the imp_docs branch September 21, 2020 14:42
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@zhaoyongjie @auxten
Improvement contributing.md (apache#10859)
600a46e 
* Improvement contributing.md

* update
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willbarrett willbarrett willbarrett approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.38.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhaoyongjie @codecov-commenter @willbarrett @mistercrunch