Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STORM-3985 - Upgrade Metrics, Jetty, Dropwizard Integration + JakartaEE API #3659

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jul 3, 2024

What is the purpose of the change

How was the change tested

  • Full CI build

Notes

  • This PR modernizes quite a lot of legacy out of date (unmaintained) 3rd party dependencies. The upgrade of metrics required the Jakarta upgrade as well, but user topologies shouldn't be affected by this change.
  • Nevertheless, I would propose, that we go for 2.7.0 as a next version because javax -> jakarta can be considered as a breaking change.

dependabot bot and others added 2 commits July 3, 2024 07:28
Bumps `metrics.version` from 3.2.6 to 4.2.26.

Updates `io.dropwizard.metrics:metrics-core` from 3.2.6 to 4.2.26
- [Release notes](https://github.com/dropwizard/metrics/releases)
- [Commits](dropwizard/metrics@v3.2.6...v4.2.26)

Updates `io.dropwizard.metrics:metrics-graphite` from 3.2.6 to 4.2.26
- [Release notes](https://github.com/dropwizard/metrics/releases)
- [Commits](dropwizard/metrics@v3.2.6...v4.2.26)

Updates `io.dropwizard.metrics:metrics-jvm` from 3.2.6 to 4.2.26
- [Release notes](https://github.com/dropwizard/metrics/releases)
- [Commits](dropwizard/metrics@v3.2.6...v4.2.26)

---
updated-dependencies:
- dependency-name: io.dropwizard.metrics:metrics-core
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: io.dropwizard.metrics:metrics-graphite
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: io.dropwizard.metrics:metrics-jvm
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@rzo1 rzo1 changed the title Draft: Upgrade Metrics STORM-3985 - Upgrade Metrics, Jetty, Dropwizard Integration + JakartaEE API Jul 3, 2024
@rzo1 rzo1 self-assigned this Jul 3, 2024
@rzo1 rzo1 marked this pull request as ready for review July 3, 2024 18:10
Copy link
Contributor

@jnioche jnioche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reiabreu
Copy link
Contributor

reiabreu commented Jul 4, 2024

Cheer @rzo1

@rzo1 rzo1 merged commit 84ccf1b into master Jul 5, 2024
18 checks passed
@rzo1 rzo1 deleted the experimental/metrics-upgrade branch July 5, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants