[SPARK-13124] [Web UI] Fixed CSS and JS issues caused by addition of JQuery DataTables #11038
Conversation
|
For reference here's what the issues look like, I returned them to their original look Fixed: |
|
retest this please |
|
@zhuoliu want to take a look since you added the DataTables |
|
Tested also for history page. Looks good to me. |
|
Test build #50630 has finished for PR 11038 at commit
|
|
So looking at the code we can't mix and match the old style and new style tables on the same page correct? |
|
@holdenk not without changing a large amount of css or html. Both styles use common table classes in their basic css. This does seem to be one way though, only the old tables are affected when both css files are available, so we could potentially edit the old tables css to force use of the old style if we want to mix and match on the same page on a case by case basis. |
|
@tgravescs since you did a lot of review on the DataTables addition do you want to take a look at this? |
|
Can you clarify when you see the exception with inspecting element? Which browser and plugin, etc? When I inspect it with firefox I don't see any errors |
|
Last I checked I was seeing it on Safari, Firefox and Chrome, no plug-ins. I'll build master and spin up a Web UI and double check right now though. |
|
Ok, I'll try it again on clean apache build also. |
|
Ok so I'm only seeing it in Safari now, and I did a couple searches based on only seeing it in Safari and I found a better fix, I'll push the change shortly |
|
It seems that when a expected map file is missing Firefox and Chrome just ignore it, Safari on the other hand throws a 404 error. Given the map file doesn't exist to begin with it makes more sense to remove the reference to it than add the map file. |
|
Test build #51059 has finished for PR 11038 at commit
|
|
+1 |
…Query DataTables Made sure the old tables continue to use the old css and the new DataTables use the new css. Also fixed it so the Safari Web Inspector doesn't throw errors when on the new DataTables pages. Author: Alex Bozarth <ajbozart@us.ibm.com> Closes apache#11038 from ajbozarth/spark13124.
…Query DataTables Made sure the old tables continue to use the old css and the new DataTables use the new css. Also fixed it so the Safari Web Inspector doesn't throw errors when on the new DataTables pages. Author: Alex Bozarth <ajbozart@us.ibm.com> Closes apache#11038 from ajbozarth/spark13124.
Made sure the old tables continue to use the old css and the new DataTables use the new css. Also fixed it so the Safari Web Inspector doesn't throw errors when on the new DataTables pages.