replace akka based names in logging code #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b709a29.
jrudolph
reviewed
Feb 16, 2023
| @@ -276,7 +276,7 @@ class SerializeSpec extends PekkoSpec(SerializationTests.serializeConf) { | |||
| } | |||
|
|
|||
| "log warning if non-Pekko serializer is configured for Pekko message" in { | |||
| EventFilter.warning(pattern = ".*not implemented by Apache Pekko.*", occurrences = 1).intercept { | |||
| EventFilter.warning(pattern = ".*not implemented by Pekko.*", occurrences = 1).intercept { | |||
There was a problem hiding this comment.
Weird, a reverse change like this is also proposed as part of #196?
|
The squash merge led to this commit: 2824a44 There appears to be no change to SerializeSpec in that commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splits out some of the changes in #184 so that can focus more on the Pekko/Akka URL protocol