Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reader and writer #16

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Refactor reader and writer #16

merged 1 commit into from
Oct 9, 2024

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Oct 9, 2024 •
edited
Loading

Purpose

  1. Change Read and Write API
  2. Get arrow schema from Java code, so Java BytesWriter doesn't need to check schema any more.

Tests

API and Format

Documentation

JingsongLi
JingsongLi approved these changes Oct 9, 2024
View reviewed changes
Copy link

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 953f30f into apache:main Oct 9, 2024
1 check passed
@yuzelin yuzelin deleted the refactor-read-write branch October 10, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingsongLi JingsongLi JingsongLi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuzelin @JingsongLi