Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow update to action without requiring a code artifact. #195

Merged
merged 3 commits into from
Jan 20, 2020
Merged

Allow update to action without requiring a code artifact. #195

merged 3 commits into from
Jan 20, 2020

Conversation

rabbah
Copy link
Member

@rabbah rabbah commented Nov 9, 2019 •
edited
Loading

Closes #93.

@codecov-io
Copy link

codecov-io commented Nov 9, 2019 •
edited
Loading

Codecov Report

Merging #195 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   99.27%   99.27%   +<.01%     
==========================================
  Files          14       14              
  Lines         411      415       +4     
==========================================
+ Hits          408      412       +4     
  Misses          3        3
Impacted Files Coverage Δ
lib/actions.js 100% <100%> (ø) ⬆️
lib/client.js 98.88% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88ce0e2...f284aa0. Read the comment docs.

@rabbah
Copy link
Member Author

rabbah commented Dec 31, 2019

@csantanapr can you review this?

@rabbah
Copy link
Member Author

rabbah commented Jan 13, 2020

Test added. Pre path test results:

  1 test failed

  actions › update a action with no paramters

  /Users/rabbah/projects/openwhisk-client-js/lib/actions.js:94

   93:     if (!isCodeAction && !isSequenceAction) {                   
   94:       throw new Error(messages.MISSING_ACTION_OR_SEQ_BODY_ERROR)
   95:     }                                                           

  Error thrown in test:

  Error {
    message: 'Missing mandatory action or sequence parameter from options.',
  }

  Actions.actionBody (lib/actions.js:94:13)
  Actions.create (lib/actions.js:56:25)
  create (test/unit/actions.test.js:416:18)

dgrove-oss
dgrove-oss approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shazron
shazron reviewed Jan 14, 2020
View reviewed changes
test/unit/actions.test.js Outdated Show resolved Hide resolved
@rabbah
Copy link
Member Author

rabbah commented Jan 20, 2020

Thanks @shazron @purplecabbage @dgrove-oss.

@rabbah rabbah merged commit 01537c4 into apache:master Jan 20, 2020
@rabbah rabbah deleted the action-update branch January 20, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shazron shazron shazron left review comments

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow updating action parameters without including action body
4 participants
@rabbah @codecov-io @shazron @dgrove-oss