Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAHOUT-1975 Add PR Template for Github PRs #313

Closed
wants to merge 1 commit into from

Conversation

rawkintrevo
Copy link
Contributor

@rawkintrevo rawkintrevo commented May 1, 2017

Purpose of PR:

This PR adds this slick template to the message box when people open PRs!

Important ToDos

Please mark each with an "x"

  • Opening PR against develop NOT master (OR feature-name if this is part of an ongoing feature development).
  • A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/ZEPPELIN/]
  • Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX
    is the JIRA number.
  • Assigned JIRA to self (almost forgot- thanks template!)
  • Created unit tests where appropriate N/A
  • Added documentation in scala docs/java docs, (and website once that
    is merged to dev) N/A
  • Added licenses correct on newly added files N/A (adding license will mess up the template)
  • Successfully built and ran all unit tests, verified that all tests
    pass locally. N/A Won't know this is working for sure until it is added to master.

If all of these things aren't complete, but you still feel it is
appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"

Oh by the way, does this change break earlier versions?
No

Is this the beginning of a larger project for which a feature branch should be made?
No- straight to dev

MAHOUT-1975 Add PR Template for Github PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant