Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-6515 Adding toString() method to o.a.k.connect.data.Field #4509

Merged
merged 1 commit into from
Feb 3, 2018
Merged

KAFKA-6515 Adding toString() method to o.a.k.connect.data.Field #4509

merged 1 commit into from
Feb 3, 2018

Conversation

gunnarmorling
Copy link
Contributor

https://issues.apache.org/jira/browse/KAFKA-6515

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

bartektartanus
bartektartanus reviewed Feb 1, 2018
View reviewed changes
connect/api/src/main/java/org/apache/kafka/connect/data/Field.java Outdated

@Override
public String toString() {
return "Schema{" +
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema? It's Field class...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Updated it. Thanks!

@asfgit
Copy link

asfgit commented Feb 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/267/

@asfgit
Copy link

asfgit commented Feb 2, 2018

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/kafka-pr-test-coverage/268/

@gunnarmorling
Copy link
Contributor Author

Hi @rhauch, @ewencp, feedback/merge welcome on that tiny improvement whose issue I spotted in JIRA and which also had been bugging me. Thanks!

hachikuji
hachikuji approved these changes Feb 3, 2018
View reviewed changes
Copy link
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. LGTM

@hachikuji hachikuji merged commit f9b56d6 into apache:trunk Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartektartanus bartektartanus bartektartanus left review comments

@hachikuji hachikuji hachikuji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gunnarmorling @asfgit @bartektartanus @hachikuji