Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit set markdown version to >= 3.0 #5959

Merged
merged 3 commits into from
Sep 27, 2018
Merged

Explicit set markdown version to >= 3.0 #5959

merged 3 commits into from
Sep 27, 2018

Conversation

manhtai
Copy link
Contributor

@manhtai manhtai commented Sep 23, 2018

Positional arguments deprecated in markdown.markdown() function of markdown 3.0.

https://github.com/Python-Markdown/markdown/blob/master/docs/change_log/release-3.0.md

@codecov-io
Copy link

Codecov Report

Merging #5959 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5959      +/-   ##
==========================================
+ Coverage   63.52%   63.56%   +0.04%     
==========================================
  Files         393      393              
  Lines       23667    23667              
  Branches     2638     2638              
==========================================
+ Hits        15034    15044      +10     
+ Misses       8620     8610      -10     
  Partials       13       13
Impacted Files Coverage Δ
superset/utils.py 89.28% <100%> (ø) ⬆️
superset/connectors/sqla/models.py 81.13% <0%> (+0.75%) ⬆️
superset/db_engine_specs.py 55.7% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5811a26...a211a82. Read the comment docs.

@mistercrunch mistercrunch merged commit 458b2b5 into apache:master Sep 27, 2018
betodealmeida pushed a commit to lyft/incubator-superset that referenced this pull request Oct 12, 2018
* Explicit set markdown version to >= 3.0

* Pinning
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants