Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change title from "hotkeys" to "keyboard shortcuts" #5688

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Change title from "hotkeys" to "keyboard shortcuts" #5688

merged 1 commit into from
Aug 21, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Aug 21, 2018 •
edited
Loading

@codecov-io
Copy link

Codecov Report

Merging #5688 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5688   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files         360      360           
  Lines       22922    22922           
  Branches     2551     2551           
=======================================
  Hits        14558    14558           
  Misses       8349     8349           
  Partials       15       15
Impacted Files Coverage Δ
...uperset/assets/src/SqlLab/components/SqlEditor.jsx 78.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50042af...d0f2b40. Read the comment docs.

williaster
williaster approved these changes Aug 21, 2018
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing us into the 21st century! ;) I think this is more in line with current web app language.

@williaster williaster merged commit fdb8001 into apache:master Aug 21, 2018
kristw added a commit to kristw/incubator-superset that referenced this pull request Aug 22, 2018
@kristw
change title from hotkeys to keyboard shortcuts (apache#5688)
375c7d7 
(cherry picked from commit fdb8001)
@kristw kristw mentioned this pull request Aug 22, 2018
Merged
@kristw kristw deleted the kristw-hotkeys branch August 22, 2018 18:14
wenchma pushed a commit to wenchma/incubator-superset that referenced this pull request Nov 16, 2018
@kristw @williaster
change title from hotkeys to keyboard shortcuts (apache#5688)
9a98372
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.28.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristw @codecov-io @williaster @mistercrunch