[bugfix] TypeError: adhocMetric.comparator.join is not a function #5661
Conversation
Somehow we have a "IN" filter where the filter is a string, not an array. While this may need to get fixed upstream as well, this prevents the explore view from completely crashing. Side note: this function looked somewhat brittle, I'm assuming it's used to keep the free form SQL tab in sync and not used to generate the actual SQL being executed.
|
@mistercrunch that's correct, it just keeps the tab in sync. I'm confused on how your |
Codecov Report
@@ Coverage Diff @@
## master #5661 +/- ##
=======================================
Coverage 63.49% 63.49%
=======================================
Files 360 360
Lines 22889 22889
Branches 2549 2549
=======================================
Hits 14534 14534
Misses 8340 8340
Partials 15 15
Continue to review full report at Codecov.
|
|
Yes clearly there's more to it, but between the different db migrations and re-interpretations of filters in different areas of the code, it's hard to understand where that bad state might have appeared and whether it's likely to happen again. Merging as a "defensive programming" approach. Side note is that we should avoid having many kinds or "generations" of filters and metrics. Hopefully we can convert the old to new ones early in the pipeline, and assume new generation metrics and filters everywhere else in the code. |
…ache#5661) Somehow we have a "IN" filter where the filter is a string, not an array. While this may need to get fixed upstream as well, this prevents the explore view from completely crashing. Side note: this function looked somewhat brittle, I'm assuming it's used to keep the free form SQL tab in sync and not used to generate the actual SQL being executed.
mistercrunch
added
🏷️ bot
Somehow we have a "IN" filter where the filter is a string, not an
array. While this may need to get fixed upstream as well, this prevents
the explore view from completely crashing.
Side note: this function looked somewhat brittle, I'm assuming it's used to keep
the free form SQL tab in sync and not used to generate the actual SQL
being executed.
@betodealmeida @GabeLoins @graceguo-supercat