[sql lab] always use NullPool #5612
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think that the only place where we want db connection pooling would be to talk to the metadata database. SQL Lab should close its connections and never pool them. Given that each Gunicorn worker will create its own pool that can lead to way too many connections opened. closes apache#4666
Codecov Report
@@ Coverage Diff @@
## master #5612 +/- ##
=======================================
Coverage 63.62% 63.62%
=======================================
Files 359 359
Lines 22820 22820
Branches 2533 2533
=======================================
Hits 14520 14520
Misses 8285 8285
Partials 15 15
Continue to review full report at Codecov.
|
john-bodley
approved these changes
Aug 14, 2018
|
@mistercrunch Can you also add Nullpool to upload csv flow's connection? |
|
@timifasubaa I think it's out of the scope of this PR. Also it looks like csv isn't using the |
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
I think that the only place where we want db connection pooling would be to talk to the metadata database. SQL Lab should close its connections and never pool them. Given that each Gunicorn worker will create its own pool that can lead to way too many connections opened. closes apache#4666
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that the only place where we want db connection pooling would be
to talk to the metadata database. SQL Lab should close its connections
and never pool them.
Given that each Gunicorn worker will create its own pool that can lead
to way too many connections opened.
closes #4666
@john-bodley @betodealmeida