-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dashboard fix]: Fix default_filters validation #5297
[dashboard fix]: Fix default_filters validation #5297
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5297 +/- ##
=========================================
+ Coverage 61.29% 61.3% +<.01%
=========================================
Files 368 368
Lines 23457 23457
Branches 2716 2716
=========================================
+ Hits 14379 14381 +2
+ Misses 9066 9064 -2
Partials 12 12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
(cherry picked from commit 17b4298)
if user update dashboard default_filters metadata with invalid slice_id (a slice not included in the dashboard), we should not add this slice id into dashboard metadata. This PR is to fix
error dictionary changed size during iteration
in python3@williaster @john-bodley @mistercrunch