asciifying http header for csv download; fixes #3952 #3975
Conversation
| @@ -2288,7 +2289,7 @@ def csv(self, client_id): | |||
| csv = df.to_csv(index=False, **config.get('CSV_EXPORT')) | |||
| response = Response(csv, mimetype='text/csv') | |||
| response.headers['Content-Disposition'] = ( | |||
| 'attachment; filename={}.csv'.format(query.name)) | |||
| 'attachment; filename={}.csv'.format(unidecode(query.name))) | |||
There was a problem hiding this comment.
Maybe this is enough?
query.name.encode('ascii', 'ignore')
There was a problem hiding this comment.
For a German there is a big difference, whether the Umlauts are entirely dropped or just replaced by their closest ascii counterpart.
I do understand that it may seem inappropriate to introduce yet another dependency for such a minor change, but I feel like this is affecting the user experience, especially of the less technically versed users.
You may safely skip the following pleadings…
There are languages, where this is even more relevant. To name an extreme example, in Turkish there exists this nice word düsündürttürücülügümüzün. Personally I think that dusundurtturuculugumuzun may still be readable, but dsndrttrclgmzn is not.
Also think of the Finnish people: A SQLLab tab on the unemployment in the town of Järvenpää työttömyys_Järvenpää could either be tyttmyys_Jrvenp or tyottomyys_Jarvenpaa.
And finally, also our Frensh speaking friends may benefit from not dropping the letters: élevé becomes lev or eleve.
|
The smile was me begging for tests. Anyway look at tests.core_tests.CoreTests.test_csv_endpoint copy tht test to something like test_csv_endpoint_works_returns_ascii_headers and test that you can decode('ascii') the header. |
|
Unidecode will be useful in other contexts, I'm ok with the new dep. |
* asciifying http header for csv download; fixes apache#3952 * fixed order of imports and added unidecode to requirements in setup.py
* asciifying http header for csv download; fixes apache#3952 * fixed order of imports and added unidecode to requirements in setup.py
mistercrunch
added
🏷️ bot
I think this should be all that is needed to fix #3952.
This way, the rather pathologic tab label
→ʬéıρδ Ñämë←will get converted toWWeird_Name, which is pretty much what I would expect it to be in non-unicode representation.