Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: save tcc action context to fencelog #4527

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feature: save tcc action context to fencelog #4527

wants to merge 10 commits into from

Conversation

pengten
Copy link
Contributor

@pengten pengten commented Apr 6, 2022 •
edited
Loading

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

添加TCC上下文存储SPI扩展能力，并扩展实现将TCC的actionContext数据存储到本地防悬挂表中。

目前TCC在方悬挂情况下，如果一阶段有三方接口调用，TCC无法进入二阶段回滚。该类问题可以参阅#4532

Ⅱ. Does this pull request fix one issue?

fixes #4423

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@pengten pengten changed the title Feature: save tcc action context to fencelog WIP:Feature: save tcc action context to fencelog Apr 6, 2022
@pengten pengten changed the title WIP:Feature: save tcc action context to fencelog Feature: save tcc action context to fencelog Apr 6, 2022
@pengten pengten marked this pull request as ready for review April 6, 2022 08:47
@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2022

This pull request introduces 2 alerts when merging 5f1932d91b22e0f2cf1cc90e219059e185a57471 into 660166a - view on LGTM.com

new alerts:

  • 2 for Spurious Javadoc @param tags

@funky-eyes funky-eyes added type: feature Category issues or prs related to feature request. mode: TCC TCC transaction mode module/tcc tcc module labels Apr 26, 2022
@pengten pengten force-pushed the feature_save_appData_to_fencelog branch from 5f1932d to 2eb3087 Compare June 6, 2022 03:30
@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #4527 (ce9b7ad) into develop (dac8aa8) will increase coverage by 0.04%.
The diff coverage is 2.04%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4527      +/-   ##
=============================================
+ Coverage      48.78%   48.83%   +0.04%     
- Complexity      4081     4168      +87     
=============================================
  Files            734      744      +10     
  Lines          25855    26602     +747     
  Branches        3191     3304     +113     
=============================================
+ Hits           12614    12990     +376     
- Misses         11899    12206     +307     
- Partials        1342     1406      +64
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...ommon/src/main/java/io/seata/common/Constants.java 100.00% <ø> (ø)
...n/src/main/java/io/seata/common/DefaultValues.java 0.00% <ø> (ø)
...src/main/java/io/seata/rm/tcc/TCCFenceHandler.java 0.00% <0.00%> (ø)
.../main/java/io/seata/rm/tcc/TCCResourceManager.java 0.00% <0.00%> (ø)
...ava/io/seata/rm/tcc/api/BusinessActionContext.java 0.00% <0.00%> (ø)
...io/seata/rm/tcc/api/BusinessActionContextUtil.java 0.00% <0.00%> (ø)
...tcc/context/store/AbstractContextStoreManager.java 0.00% <0.00%> (ø)
...tcc/context/store/FenceLogContextStoreManager.java 0.00% <0.00%> (ø)
...m/tcc/context/store/ReportContextStoreManager.java 0.00% <0.00%> (ø)
... and 84 more

@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2022

This pull request introduces 2 alerts when merging 2eb30879587b95a9f9bde353efc6a8e0a5ae0fb8 into 29d83e8 - view on LGTM.com

new alerts:

  • 2 for Spurious Javadoc @param tags

@lgtm-com
Copy link

lgtm-com bot commented Jun 10, 2022

This pull request introduces 2 alerts when merging 9fbbf9ecff13b1efa7ca408491190d7e3090ceb3 into 5729a38 - view on LGTM.com

new alerts:

  • 2 for Spurious Javadoc @param tags

@pengten pengten force-pushed the feature_save_appData_to_fencelog branch from 9fbbf9e to bf69b49 Compare October 5, 2022 04:32
@lgtm-com
Copy link

lgtm-com bot commented Oct 17, 2022

This pull request introduces 1 alert when merging 9edea75 into caeb231 - view on LGTM.com

new alerts:

  • 1 for Spurious Javadoc @param tags

@pengten
Copy link
Contributor Author

pengten commented Nov 6, 2022

  1. If the user has not added an application after enabling this function_ Data field, you should give a friendly error message.
  2. Add some flowcharts or design diagrams to supplement.
  3. Supplementary code notes.
  4. If the store type obtained from the context is null, it should be TC by default.

1.用户开启该功能却没有新增application_data字段，应该给个友好的报错。
2.添加一些流程图或设计图进行补充。
3.补充代码注释。
4.如果从上下文中获取store type 为空，应该默认为TC。

@pengten
Copy link
Contributor Author

pengten commented Nov 6, 2022

At present, the support of TCC anti suspension for third-party interface calls has some shortcomings. More best practices may be required to help users use TCC correctly.

目前 TCC 防悬挂对三方接口调用的支持存在一些不足，针对 TCC 这块可能需要提供更多的最佳实践来帮助用户正确的使用。

@pengten pengten force-pushed the feature_save_appData_to_fencelog branch from c3e5299 to ce9b7ad Compare December 9, 2022 10:24
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pengten pengten mentioned this pull request Jan 31, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bughue Bughue Bughue left review comments

@objcoding objcoding Awaiting requested review from objcoding

@wangliang181230 wangliang181230 Awaiting requested review from wangliang181230

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
mode: TCC TCC transaction mode module/tcc tcc module type: feature Category issues or prs related to feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tcc support one-phase data storage that stores local table
5 participants
@pengten @codecov-commenter @CLAassistant @Bughue @funky-eyes