optimize: optimize the versions of the dependencies #4227
Conversation
|
done，剩余的也全部改成https了 |
Codecov Report
@@ Coverage Diff @@
## develop #4227 +/- ##
=============================================
+ Coverage 48.93% 49.02% +0.08%
Complexity 3953 3953
=============================================
Files 733 733
Lines 24968 24968
Branches 3087 3088 +1
=============================================
+ Hits 12219 12240 +21
+ Misses 11454 11433 -21
Partials 1295 1295
|
optimize: 添加sqlParser的配置相关的补充信息。
# Conflicts: # rm-datasource/src/main/java/io/seata/rm/datasource/sql/SQLVisitorFactory.java # rm-datasource/src/main/java/io/seata/rm/datasource/util/JdbcUtils.java
| @@ -517,16 +452,108 @@ | |||
| </exclusion> | |||
| </exclusions> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
It is recommended to declare versions of important dependencies. Spring-boot-dependencies are just an import POM. We should declare versions of important dependencies, such as Redis, Mariadb, These supported versions should not be limited by the scope of Spring-boot-dependencies, especially since Seata-Server also depend on seata-dependencies.
建议声明重要依赖的版本。spring-boot-dependencies 只是个import pom，我们应该声明对重要依赖支持的版本，比如pom中的redis，mariadb，这些支持的版本不应该受限于spring-boot-dependencies 的scope，特别是seata-server也会依赖seata-dependencies。
There was a problem hiding this comment.
done, the versions of core dependencies is set in server/pom.xml
There was a problem hiding this comment.
It is recommended to keep dependencies like mysql, Postgres, H2, mariadb directly in dependencies. pom. The dependency declaration in Dependencies is only dependencyManagement. Have we fully tested the above dependencies in Spring-boot? In fact, our application module does not directly rely on DB-driver dependencies such as mysql, Postgres, H2, Mariadb, etc. except server, but it can indicate which versions we recommend and adapt. Users may be able to manage dependencies using import seta-dependency.
wangliang181230
requested review from
slievrly
and removed request for
jsbxyyx
slievrly
changed the title
optimize: Unified management versions of the dependencies, and upgrade spring-boot
优化：统一管理依赖的版本，并且升级spring-boot到2.4.13
统一管理依赖的版本：
seata-dependencies中。升级spring-boot：
springboot版本到2.4.13，全局引入spring-boot-dependencies，同时在seata-dependencies中移除在spring-boot-dependencies中已存在的依赖。@Configuration->@Configuration(proxyBeanMethods = false)：spring-boot项目启动时，不对这些配置类进行代理，加快项目启动速度。说明：全局引入spring-boot的目的，是切换spring-boot版本，可以同时切换由
spring-boot-dependencies引进来的依赖的版本。可通过切换spring-boot版本，对多个依赖的版本进行兼容性测试。