Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]Method checks the size of a collection against zero rather than using isEmpty() [WebhookTopicConfig] #2169

Closed
2 tasks done
danshow opened this issue Nov 11, 2022 · 1 comment · Fixed by #2172
Closed
2 tasks done

[Enhancement]Method checks the size of a collection against zero rather than using isEmpty() [WebhookTopicConfig] #2169

danshow opened this issue Nov 11, 2022 · 1 comment · Fixed by #2172
Assignees
@danshow
Labels
enhancement New feature or request
Milestone
1.7.0

Comments

@danshow
Copy link
Contributor

danshow commented Nov 11, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

Enhancement Request

For better code clarity, it is better to just use col.isEmpty().

Describe the solution you'd like

For better code clarity, it is better to just use col.isEmpty().

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@danshow danshow added the enhancement New feature or request label Nov 11, 2022
@github-actions
Copy link
Contributor

Welcome to the Apache EventMesh (incubating) community!!
We are glad that you are contributing by opening this issue. :D

Please make sure to include all the relevant context.
We will be here shortly.

If you are interested in contributing to our project, please let us know!
You can check out our contributing guide on contributing to EventMesh.

Want to get closer to the community?

WeChat Group：
wechat_qr

Mailing Lists:

Name Description Subscribe Unsubscribe Archive
Users User support and questions mailing list Subscribe Unsubscribe Mail Archives
Development Development related discussions Subscribe Unsubscribe Mail Archives
Commits All commits to repositories Subscribe Unsubscribe Mail Archives

danshow added a commit to danshow/incubator-eventmesh that referenced this issue Nov 11, 2022
@danshow
optise list empty check for issue apache#2169
f701cf0
@danshow danshow mentioned this issue Nov 11, 2022
Merged
@xwm1992 xwm1992 changed the title Method checks the size of a collection against zero rather than using isEmpty() [WebhookTopicConfig] [Enhancement]Method checks the size of a collection against zero rather than using isEmpty() [WebhookTopicConfig] Nov 12, 2022
xwm1992 added a commit that referenced this issue Nov 12, 2022
@xwm1992
Merge pull request #2172 from danshow/master
64deeb5 
[ISSUE #2169] Optmise list empty check 
close #2169
@xwm1992 xwm1992 added this to the 1.7.0 milestone Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danshow danshow

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #2169] Optmise list empty check danshow/incubator-eventmesh
2 participants
@danshow @xwm1992